Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky: TestAutoscalerWebhook #812

Merged
merged 2 commits into from
Jun 7, 2019
Merged

Flaky: TestAutoscalerWebhook #812

merged 2 commits into from
Jun 7, 2019

Conversation

markmandel
Copy link
Member

Replace flaky elements with polling strategy.

@markmandel
Flaky: TestAutoscalerWebhook
c6f9580 
Replace flaky elements with polling strategy.
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/tests Unit tests, e2e tests, anything to make sure things don't break labels Jun 6, 2019
@markmandel
Copy link
Member Author

/cc @aLekSer for visibility 👍

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ebab15e0-79bb-4af4-81fc-2492f3dfed94

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/812/head:pr_812 && git checkout pr_812
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-c6f9580

@aLekSer
Copy link
Collaborator

aLekSer commented Jun 6, 2019

Nice fix, it is needed to write tests without time.Sleep(). Will be creating new with this idea in mind.

This was referenced Jun 7, 2019
Merged
Merged
cyriltovena
cyriltovena approved these changes Jun 7, 2019
View reviewed changes
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markmandel
Copy link
Member Author

Thank you! 🎉

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 81e7ab8d-3257-412e-9fdb-cbc3c233eadb

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/812/head:pr_812 && git checkout pr_812
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-716e75c

@markmandel markmandel merged commit a027653 into googleforgames:master Jun 7, 2019
@markmandel markmandel deleted the flaky/TestAutoscalerWebhook branch June 7, 2019 19:43
@markmandel markmandel added this to the 0.11.0 milestone Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @agones-bot @aLekSer @cyriltovena