Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for gameServerCacheEntry in GameServerAllocation controller #754

Merged
merged 2 commits into from
May 1, 2019
Merged

Add tests for gameServerCacheEntry in GameServerAllocation controller #754

merged 2 commits into from
May 1, 2019

Conversation

markmandel
Copy link
Member

This moves the cache into its own file to make things a bit more readable, and also to implement some tests for the struct.

@markmandel
Add tests for gameServerCacheEntry in GameServerAllocation controller
e6e2a99 
This moves the cache into its own file to make things a bit more
readable, and also to implement some tests for the struct.
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label May 1, 2019
@markmandel
Copy link
Member Author

/cc @ilkercelikyilmaz please let me know if you see any issues

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 6fe17b85-cdcd-438a-9708-4455ec180e37

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/754/head:pr_754 && git checkout pr_754
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-e6e2a99

cyriltovena
cyriltovena approved these changes May 1, 2019
View reviewed changes
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: c3181411-7714-436a-83f0-89c829563581

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 298e70a3-1a89-448f-b041-f14d276e7304

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/754/head:pr_754 && git checkout pr_754
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-0906f40

@markmandel markmandel merged commit 2b08d46 into googleforgames:master May 1, 2019
@markmandel markmandel deleted the cleanup/gsa-controller branch May 1, 2019 19:46
@ilkercelikyilmaz
Copy link
Contributor

/cc @ilkercelikyilmaz please let me know if you see any issues

Sure. I am going to run a load test and let you know if I see something unexpected

@markmandel
Copy link
Member Author

Sweet - should be all the same - I just moved it to a new file, and added some unit tests. No logic changes.

@markmandel markmandel added this to the 0.10.0 milestone May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @agones-bot @ilkercelikyilmaz @cyriltovena