Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for health check stability issues #55

Merged
merged 1 commit into from
Jan 9, 2018
Merged

Conversation

markmandel
Copy link
Member

Because of race conditions, on non-warm CI builds, health checks can occasionally fail.

This should solve this problem 🤞

Because of race conditions, on non-warm CI
builds, health checks can occasionally fail.

This should solve this problem 🤞
@markmandel markmandel added kind/bug These are bugs. area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. labels Jan 9, 2018
@markmandel
Copy link
Member Author

@dzlier-gcp I think this will solve the issue with the healthchecks we've been seeing.

Also figured you might be interested - it's also a nice little util lib backed into K8s's client-go.

@dzlier-gcp
Copy link
Contributor

LGTM, though any time I see duplicated code like this (which is partially my fault since I did 1.5 of the health checks) it makes me itch. I wonder if, when, and in what way we could consolidate any of this.

@markmandel
Copy link
Member Author

I tend to work on a 'if you do something 3 times, then consolidate' - but if you feel strongly, happy to look at PRs ;)

@markmandel markmandel merged commit 6282567 into master Jan 9, 2018
@markmandel markmandel deleted the bug/fix-heatlh-tests branch January 9, 2018 18:28
@markmandel markmandel added this to the 0.1 milestone May 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/bug These are bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants