Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential data race in allocation counter #525

Merged
merged 2 commits into from
Jan 29, 2019
Merged

Fix potential data race in allocation counter #525

merged 2 commits into from
Jan 29, 2019

Conversation

markmandel
Copy link
Member

Found a rare data race in tests for the allocation counter.

Could have potentially have leaked into production code, so here is a fix.

@markmandel
Fix potential data race in allocation counter
c5cae7b 
Found a rare data race in tests for the allocation counter.

Could have potentially have leaked into production code,
so here is a fix.
@markmandel markmandel added the kind/bug These are bugs. label Jan 29, 2019
@markmandel markmandel added this to the 0.8.0 milestone Jan 29, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 635cd61f-f704-49ad-b1ce-400767b6c057

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website will exist for the next 30 days:

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/525/head:pr_525 && git checkout pr_525
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-c5cae7b

@jkowalski
Copy link
Contributor

LGTM

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 18b4d20c-d8b7-42ff-8605-2213ccbe95c5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website will exist for the next 30 days:

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/525/head:pr_525 && git checkout pr_525
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-a7328ac

@markmandel markmandel merged commit d1bf30f into googleforgames:master Jan 29, 2019
@markmandel markmandel deleted the bug/counter-race branch January 29, 2019 21:40
@WontonSam WontonSam mentioned this pull request Dec 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkowalski jkowalski jkowalski approved these changes

Assignees
No one assigned
Labels
kind/bug These are bugs.
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@markmandel @agones-bot @jkowalski