Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Canary Testing Documentation #3760

Merged
merged 6 commits into from
Apr 16, 2024
Merged

Update Canary Testing Documentation #3760

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
60dc342
Docs: Update Canary Testing
Kalaiselvi84 Apr 12, 2024
1c63778
review changes
Kalaiselvi84 Apr 15, 2024
aedf093
Merge branch 'main' into canary-test
Kalaiselvi84 Apr 15, 2024
3c07b6d
allocate GameSErvers from canary or fallback to stable fleet if none
Kalaiselvi84 Apr 16, 2024
a312f0b
Merge branch 'main' into canary-test
Kalaiselvi84 Apr 16, 2024
877678d
Merge branch 'main' into canary-test
igooch Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions site/content/en/docs/Integration Patterns/canary-testing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,13 @@ To ensure we don't have to change the Allocation system every time we have a can
state that in our system, the label `canary: "true"` will be added to any canary `Fleet` in the cluster.

```yaml
apiVersion: "allocation.agones.dev/v1"
apiVersion: allocation.agones.dev/v1
kind: GameServerAllocation
spec:
preferred:
selectors:
- matchLabels:
canary: "true"
required:
matchLabels:
agones.dev/fleet: stable
agones.dev/fleet: stable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So right now this is a "canary and fleet is 'stable'" - what we actually want is "check the canary label'ed GameServers, and if there are none left, then go to the 'stable' fleet.

So we want this instead:

apiVersion: allocation.agones.dev/v1
kind: GameServerAllocation
spec:
  selectors:
    - matchLabels:
        canary: "true"
    - matchLabels:
        agones.dev/fleet: stable

Which will first look for the first selector, and if it fails go to the second.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made the changes you recommended.

```

The above `Allocation` will then preferentially choose the `Fleet` that has `GameServers` with the label and key
Expand Down
Loading