Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #374

Merged
merged 2 commits into from
Oct 5, 2018
Merged

Fix typo #374

merged 2 commits into from
Oct 5, 2018

Conversation

maxpain
Copy link
Contributor

@maxpain maxpain commented Oct 4, 2018

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5aaebf22-e1b3-4832-8dc8-aff5bab03a50

The following development artifacts have been built, and will exist for the next 30 days:

(experimental) To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/374/head:pr_374 && git checkout pr_374
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.5.0-f9ad30f

@maxpain
Copy link
Contributor Author

maxpain commented Oct 5, 2018

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ec8990d4-058f-4802-a035-5caecbe5dbd7

The following development artifacts have been built, and will exist for the next 30 days:

(experimental) To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/374/head:pr_374 && git checkout pr_374
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.5.0-43fd198

@markmandel markmandel merged commit aafa806 into googleforgames:master Oct 5, 2018
@markmandel markmandel added this to the 0.5.0 milestone Oct 8, 2018
@markmandel markmandel added kind/documentation Documentation for Agones kind/cleanup Refactoring code, fixing up documentation, etc labels Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants