Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding build targets for the simple-genai-server example. #3689

Merged

Conversation

roberthbailey
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it: Adds some missing build targets.

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@github-actions github-actions bot added kind/cleanup Refactoring code, fixing up documentation, etc size/XS labels Mar 8, 2024
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 6633f48b-3347-4007-be2f-1ef501c5840a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey
Copy link
Member Author

Flake on the 1.26 cluster:

VERBOSE:     gameserverallocation_test.go:1397: could not completed gsa1 allocation : an error on the server ("error updating allocated gameserver: Operation cannot be fulfilled on gameservers.agones.dev \"preferred-gpjwz-cjzbh-87p6n\": the object has been modified; please apply your changes to the latest version and try again") has prevented the request from succeeding (post gameserverallocations.allocation.agones.dev)
VERBOSE: I0309 00:27:11.516074     421 request.go:696] Waited for 1.110355794s due to client-side throttling, not priority and fairness, request: POST:https://35.221.181.120/apis/allocation.agones.dev/v1/namespaces/1709943961/gameserverallocations
VERBOSE: time="2024-03-09 00:27:12.114" level=info msg="Scaling fleet" fleet=preferred-gpjwz patch="[{ \"op\": \"replace\", \"path\": \"/spec/replicas\", \"value\": 120 }]" scale=120
VERBOSE: I0309 00:27:21.715535     421 request.go:696] Waited for 1.780056591s due to client-side throttling, not priority and fairness, request: POST:https://35.221.181.120/apis/allocation.agones.dev/v1/namespaces/1709943961/gameserverallocations
VERBOSE: time="2024-03-09 00:27:27.460" level=info msg="Finished Allocation."
VERBOSE:     gameserverallocation_test.go:1417: 
VERBOSE:         	Error Trace:	/go/src/agones.dev/agones/test/e2e/gameserverallocation_test.go:1417
VERBOSE:         	Error:      	Not equal: 
VERBOSE:         	            	expected: 100
VERBOSE:         	            	actual  : 99
VERBOSE:         	Test:       	TestGameServerAllocationDuringMultipleAllocationClients
VERBOSE: --- FAIL: TestGameServerAllocationDuringMultipleAllocationClients (85.45s)
VERBOSE: FAIL
VERBOSE: time="2024-03-09 00:27:28.610" level=info msg="Namespace 1709943961 is deleted"
VERBOSE: FAIL	agones.dev/agones/test/e2e	88.142s

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: da0289ef-a417-41f0-8d84-376506161900

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3689/head:pr_3689 && git checkout pr_3689
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.39.0-dev-33d1fc3-amd64

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5f6bd9f7-1410-4b37-8d6d-5cce9e30619c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3689/head:pr_3689 && git checkout pr_3689
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.39.0-dev-24d88b7-amd64

Copy link
Collaborator

@igooch igooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roberthbailey roberthbailey merged commit 66cd0e2 into googleforgames:main Mar 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants