by default disable agones-metrics nodepools

[ashutosji]

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it: Since we're not installing Prometheus or Graphana on these clusters. By default, agones-metrics nodepools would be disabled as nodes aren't doing anything. However, we can enable it when needed by passing -var enableAgonesMetricsNodepool=true on the terraform apply command.

Which issue(s) this PR fixes: #3669

Closes #3669

Special notes for your reviewer:

[agones-bot]

Build Succeeded 👏

Build Id: 2b0026cf-6af8-4593-a2e0-b61d400d5d46

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.39.0-dev-5f8dd01-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.39.0-dev-5f8dd01-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.39.0-dev-5f8dd01-linux-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.39.0-dev-5f8dd01-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.39.0-dev-5f8dd01-amd64
• Linux C++ SDK (build): agonessdk-1.39.0-dev-5f8dd01-amd64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.39.0-dev-5f8dd01-amd64.zip

A preview of the website (the last 30 builds are retained):

• https://5f8dd01-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/3672/head:pr_3672 && git checkout pr_3672
• helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.39.0-dev-5f8dd01-amd64

[markmandel]

Thanks for sending this through!

To compete this enhancement, can we also add documentation here for the new parameters please?
https://agones.dev/site/docs/installation/terraform/gke/#installation

You can see details on writing docs here: https://agones.dev/site/docs/contribute/ - the new parameters will need to go behind a feature shortcode.

Also, we'll want a variable here: https://github.com/googleforgames/agones/blob/main/build/includes/google-cloud.mk with it enabled to be on, so that the default test cluster we use for development still has the metric nodes.

[ashutosji]

Thanks for sending this through!

To compete this enhancement, can we also add documentation here for the new parameters please? https://agones.dev/site/docs/installation/terraform/gke/#installation

You can see details on writing docs here: https://agones.dev/site/docs/contribute/ - the new parameters will need to go behind a feature shortcode.

Also, we'll want a variable here: https://github.com/googleforgames/agones/blob/main/build/includes/google-cloud.mk with it enabled to be on, so that the default test cluster we use for development still has the metric nodes.

@markmandel,
Thanks for the review.
I have updated the changes as suggested by you.
Just a quick question, Shall I add next upcoming version in the shortcode or current version(1.38.0) is ok?

[agones-bot]

Build Succeeded 👏

Build Id: 88c60721-8282-4eac-9cde-fa92bfef201f

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.39.0-dev-4f78e8d-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.39.0-dev-4f78e8d-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.39.0-dev-4f78e8d-linux-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.39.0-dev-4f78e8d-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.39.0-dev-4f78e8d-amd64
• Linux C++ SDK (build): agonessdk-1.39.0-dev-4f78e8d-amd64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.39.0-dev-4f78e8d-amd64.zip

A preview of the website (the last 30 builds are retained):

• https://4f78e8d-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/3672/head:pr_3672 && git checkout pr_3672
• helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.39.0-dev-4f78e8d-amd64

[markmandel]

Small revert, but otherwise, LGTM 👍🏻

[markmandel]

Suggested change

	// To enable agones-metrics add below command in `terraform apply`:
	// -var enable_agones_metrics_nodepool=true

I think this can be rolled back - we don't have any other variable specific docs in a comment here.

[ashutosji]

I think this can be rolled back - we don't have any other variable specific docs in a comment here.

Thanks for the review and suggestions.
Done!

[markmandel]

👍🏻

[agones-bot]

Build Succeeded 👏

Build Id: a70ae89a-936e-4c74-965f-de10883b1585

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.39.0-dev-fd2f2b6-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.39.0-dev-fd2f2b6-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.39.0-dev-fd2f2b6-linux-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.39.0-dev-fd2f2b6-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.39.0-dev-fd2f2b6-amd64
• Linux C++ SDK (build): agonessdk-1.39.0-dev-fd2f2b6-amd64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.39.0-dev-fd2f2b6-amd64.zip

A preview of the website (the last 30 builds are retained):

• https://fd2f2b6-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/3672/head:pr_3672 && git checkout pr_3672
• helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.39.0-dev-fd2f2b6-amd64

[agones-bot]

Build Succeeded 👏

Build Id: f48f5dea-8c2e-477d-8b66-3df3d1f919a9

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.39.0-dev-c1693dc-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.39.0-dev-c1693dc-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.39.0-dev-c1693dc-linux-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.39.0-dev-c1693dc-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.39.0-dev-c1693dc-amd64
• Linux C++ SDK (build): agonessdk-1.39.0-dev-c1693dc-amd64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.39.0-dev-c1693dc-amd64.zip

A preview of the website (the last 30 builds are retained):

• https://c1693dc-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/3672/head:pr_3672 && git checkout pr_3672
• helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.39.0-dev-c1693dc-amd64