Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Counter conformance test #3488

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Adds Counter conformance test #3488

merged 3 commits into from
Nov 9, 2023

Conversation

igooch
Copy link
Collaborator

@igooch igooch commented Nov 3, 2023

What type of PR is this?

/kind feature

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Working on #2716

Special notes for your reviewer:

@github-actions github-actions bot added the kind/feature New features for Agones label Nov 3, 2023
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 0e9932b0-0716-414c-9cdb-96dff47a80d0

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from 665d508 to cb4ba73 Compare November 3, 2023 22:58
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: e2b5d3de-cbe3-4cb1-ba05-1340be93a740

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch 2 times, most recently from 3780c63 to bec7a70 Compare November 6, 2023 17:23
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5914a0c8-e8ff-4e95-8f4e-4e10a3894441

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3488/head:pr_3488 && git checkout pr_3488
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-bec7a70-amd64

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from bec7a70 to 1b282eb Compare November 7, 2023 00:35
@google-oss-prow google-oss-prow bot removed the size/S label Nov 7, 2023
@igooch igooch marked this pull request as ready for review November 7, 2023 00:35
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 2f6e3177-9f43-4bda-9017-b1e0985ca779

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from 1b282eb to dde9c78 Compare November 7, 2023 01:03
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: c8476508-ca6e-4337-80d7-aecc36acb1dc

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@google-oss-prow google-oss-prow bot added size/L and removed size/M labels Nov 7, 2023
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 52729501-790b-4995-86ea-5dc0b57427f8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3488/head:pr_3488 && git checkout pr_3488
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-8b84fa2-amd64

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 62effd0c-b8f9-400c-af9e-0e851055c016

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from 3d449da to cd5419a Compare November 8, 2023 17:29
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c614d8d7-ff70-48c3-b809-b2e7a308b9c8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3488/head:pr_3488 && git checkout pr_3488
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-cd5419a-amd64

markmandel
markmandel approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like it!

@google-oss-prow google-oss-prow bot added the lgtm label Nov 9, 2023
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: igooch, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel merged commit e12ae6f into googleforgames:main Nov 9, 2023
3 checks passed
@igooch igooch mentioned this pull request Jan 18, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

@EricFortin EricFortin Awaiting requested review from EricFortin

@aLekSer aLekSer Awaiting requested review from aLekSer

Assignees

@markmandel markmandel

Labels
approved kind/feature New features for Agones lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igooch @agones-bot @markmandel