Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Examples: supertuxkart and xonotic #3463

Merged
merged 5 commits into from
Oct 28, 2023

Conversation

Kalaiselvi84
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@github-actions github-actions bot added the kind/cleanup Refactoring code, fixing up documentation, etc label Oct 26, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kalaiselvi84, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -24,5 +24,5 @@ spec:
spec:
containers:
- name: xonotic
image: us-docker.pkg.dev/agones-images/examples/xonotic-example:1.2
image: us-docker.pkg.dev/agones-images/examples/xonotic-example:1.3
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we fine with 1.3, or should we update it to 0.13?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like in #3027 we went from 0.9 to 1.0 instead of to 0.10.

Now that we are at 1.2 we should just keep bumping the minor version, so going from 1.2 to 1.3 seems reasonable.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f3ff2c0c-7cbe-4a68-bcd6-277b6ccba954

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3463/head:pr_3463 && git checkout pr_3463
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-dc2c99f-amd64

@markmandel markmandel enabled auto-merge (squash) October 27, 2023 16:07
@google-oss-prow google-oss-prow bot removed the lgtm label Oct 27, 2023
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2c1b0fce-3eee-468e-a923-ce2b7f458bd5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3463/head:pr_3463 && git checkout pr_3463
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-0678305-amd64

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 88bd7925-9d36-4e48-9e9d-a30ecc2a6352

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3463/head:pr_3463 && git checkout pr_3463
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-303ae33-amd64

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 39fb7b71-2f15-4978-a879-9e4d44bb4c25

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3463/head:pr_3463 && git checkout pr_3463
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-a03f203-amd64

@markmandel markmandel merged commit 96dec39 into googleforgames:main Oct 28, 2023
3 checks passed
@Kalaiselvi84 Kalaiselvi84 deleted the update-dependencies branch March 15, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants