Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't log when a pod can't be found on startup #3393

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Sometimes pods can't be found yet - that's not a big deal, and shouldn't be logged.

So we're not doing that now!

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Also found a superfluous creation of a LogEntry that wasn't doing anything so removed that too.

Sometimes pods can't be found yet - that's not a big deal, and
shouldn't be logged.

So we're not doing that now!

Also found a superfluous creation of a LogEntry that wasn't doing
anything so removed that too.
@markmandel markmandel added the area/operations Installation, updating, metrics etc label Sep 20, 2023
@github-actions github-actions bot added the kind/cleanup Refactoring code, fixing up documentation, etc label Sep 20, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, markmandel, zmerlynn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel enabled auto-merge (squash) September 20, 2023 23:55
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 85ced8c7-a9d6-45a9-98d1-9c7ac1ddc5f8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3393/head:pr_3393 && git checkout pr_3393
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-0682d3a-amd64

@markmandel markmandel merged commit e4f8ac1 into googleforgames:main Sep 21, 2023
2 of 3 checks passed
@markmandel markmandel deleted the logging/less-verbose branch September 21, 2023 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/operations Installation, updating, metrics etc kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants