Add conformance test implementation for C# SDK #3392

yoshd · 2023-09-20T20:17:33Z

What type of PR is this?

/kind feature

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #2803

Special notes for your reviewer:

agones-bot · 2023-09-20T20:31:25Z

Build Failed 😱

Build Id: 602ee5bd-289c-41f6-8ee5-22492eda9bce

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-09-21T13:51:32Z

Build Failed 😱

Build Id: 71cc5f6b-7930-49e1-8c2d-3bc70f8a2752

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-09-21T14:54:43Z

Build Failed 😱

Build Id: 1fc3a87b-4e5c-41ab-be82-f682ff67ddd2

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-09-21T15:11:24Z

Build Failed 😱

Build Id: a1161430-157f-433a-ad71-2456d0758756

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel

You know - i swore we had one of these! Thanks for writing this!

markmandel · 2023-09-21T17:12:30Z

build/includes/sdk.mk

+	DOCKER_RUN_ARGS="$(DOCKER_RUN_ARGS) -e RUN_ASYNC=true" $(MAKE) run-sdk-conformance-test SDK_FOLDER=csharp GRPC_PORT=9005 HTTP_PORT=9105
+	# run with feature flags enabled
+	$(MAKE) run-sdk-conformance-test SDK_FOLDER=csharp GRPC_PORT=9005 HTTP_PORT=9105 FEATURE_GATES=PlayerTracking=true TESTS=$(DEFAULT_CONFORMANCE_TESTS),$(ALPHA_CONFORMANCE_TESTS)
+	# run with feature flags enabled and with RUN_ASYNC=true


You don't need RUN_ASYNC -- it was Rust specific.

You can likely copy from run-sdk-conformance-test-go instead.

Thank you for taking the time to review !
fixed: f645e0c

markmandel · 2023-09-21T17:12:43Z

test/sdk/csharp/Program.cs

@@ -0,0 +1,164 @@
+using Agones;


Apache licence please 😄

Thank you. Fixed 2dfe70a

agones-bot · 2023-09-21T17:39:30Z

Build Failed 😱

Build Id: c2792957-b5cd-4f46-9134-2092751851ad

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2023-09-21T17:46:15Z

Found where the build was failing

Step #20 - "tests": Starting test execution, please wait...
Step #20 - "tests": A total of 1 test files matched the specified pattern.
Step #20 - "tests": Testhost process for source(s) '/go/src/agones.dev/agones/sdks/csharp/test/bin/Release/netcoreapp3.1/Agones.Test.dll' exited with error: You must install or update .NET to run this application.
Step #20 - "tests": App: /root/.nuget/packages/microsoft.testplatform.testhost/15.9.0/lib/netstandard1.5/testhost.dll
Step #20 - "tests": Architecture: x64
Step #20 - "tests": Framework: 'Microsoft.NETCore.App', version '3.1.0' (x64)
Step #20 - "tests": .NET location: /usr/share/dotnet/
Step #20 - "tests": The following frameworks were found:
Step #20 - "tests":   7.0.10 at [/usr/share/dotnet/shared/Microsoft.NETCore.App]
Step #20 - "tests": Learn about framework resolution:
Step #20 - "tests": https://aka.ms/dotnet/app-launch-failed
Step #20 - "tests": To install missing framework, download:
Step #20 - "tests": https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=3.1.0&arch=x64&rid=debian.11-x64
Step #20 - "tests": . Please check the diagnostic logs for more information.
Step #20 - "tests": 
Step #20 - "tests": Test Run Aborted.
Step #20 - "tests": make[1]: *** [includes/sdk.mk:88: run-sdk-command] Error 1
Step #20 - "tests": make: *** [includes/sdk.mk:84: run-sdk-command-csharp] Error 2

yoshd · 2023-09-21T17:57:25Z

Found where the build was failing

Thank you for finding that.
It seems to be solved by installing both dotnet-sdk-7.0 and dotnet-sdk-3.1.
(Removing the old dotnet-sdk will be resolved in #3397)

agones-bot · 2023-09-21T19:05:23Z

Build Succeeded 👏

Build Id: 41a54195-b244-4cd7-a241-189103f808d1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://72ff621-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3392/head:pr_3392 && git checkout pr_3392
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-72ff621-amd64

markmandel

Thanks!

google-oss-prow · 2023-09-21T22:46:39Z

New changes are detected. LGTM label has been removed.

google-oss-prow · 2023-09-21T22:46:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, yoshd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

agones-bot · 2023-09-22T00:21:32Z

Build Succeeded 👏

Build Id: 3c925c37-5435-4e38-9a56-15f034bba1cc

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://a5d1e66-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3392/head:pr_3392 && git checkout pr_3392
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-a5d1e66-amd64

Add conformance test implementation for C# SDK

7680635

google-oss-prow bot added do-not-merge/work-in-progress size/L labels Sep 20, 2023

github-actions bot added the kind/feature New features for Agones label Sep 20, 2023

google-oss-prow bot requested review from EricFortin and markmandel September 20, 2023 20:17

add successful log

a074e0e

yoshd added 3 commits September 21, 2023 23:27

Fix SetLabel/SetAnnotation tests

ff7e37e

Remove garbage

685a5df

Rename sdk test file

513cf29

yoshd added 2 commits September 21, 2023 23:56

Fix SetLabel test

efb936f

Merge branch 'main' into add_csharp_conformance_test

870976b

markmandel reviewed Sep 21, 2023

View reviewed changes

yoshd added 2 commits September 22, 2023 02:19

Remove unnecessary

f645e0c

Add Apache licence

2dfe70a

yoshd marked this pull request as ready for review September 21, 2023 17:29

google-oss-prow bot removed the do-not-merge/work-in-progress label Sep 21, 2023

google-oss-prow bot requested a review from markmandel September 21, 2023 17:29

yoshd mentioned this pull request Sep 21, 2023

Change to use grpc-dotnet instead of Grpc.Core in C# SDK #3397

Merged

Fixed to also install dotnet-sdk-3.1

72ff621

markmandel approved these changes Sep 21, 2023

View reviewed changes

google-oss-prow bot assigned markmandel Sep 21, 2023

google-oss-prow bot added the lgtm label Sep 21, 2023

markmandel enabled auto-merge (squash) September 21, 2023 22:46

Merge branch 'main' into add_csharp_conformance_test

a5d1e66

google-oss-prow bot removed the lgtm label Sep 21, 2023

google-oss-prow bot added the approved label Sep 21, 2023

markmandel merged commit c93f709 into googleforgames:main Sep 22, 2023
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add conformance test implementation for C# SDK #3392

Add conformance test implementation for C# SDK #3392

yoshd commented Sep 20, 2023 •

edited

Loading

agones-bot commented Sep 20, 2023

agones-bot commented Sep 21, 2023

agones-bot commented Sep 21, 2023

agones-bot commented Sep 21, 2023

markmandel left a comment

markmandel Sep 21, 2023

yoshd Sep 21, 2023

markmandel Sep 21, 2023

yoshd Sep 21, 2023

agones-bot commented Sep 21, 2023

markmandel commented Sep 21, 2023

yoshd commented Sep 21, 2023 •

edited

Loading

agones-bot commented Sep 21, 2023

markmandel left a comment

google-oss-prow bot commented Sep 21, 2023

google-oss-prow bot commented Sep 21, 2023

agones-bot commented Sep 22, 2023

Add conformance test implementation for C# SDK #3392

Add conformance test implementation for C# SDK #3392

Conversation

yoshd commented Sep 20, 2023 • edited Loading

agones-bot commented Sep 20, 2023

agones-bot commented Sep 21, 2023

agones-bot commented Sep 21, 2023

agones-bot commented Sep 21, 2023

markmandel left a comment

Choose a reason for hiding this comment

markmandel Sep 21, 2023

Choose a reason for hiding this comment

yoshd Sep 21, 2023

Choose a reason for hiding this comment

markmandel Sep 21, 2023

Choose a reason for hiding this comment

yoshd Sep 21, 2023

Choose a reason for hiding this comment

agones-bot commented Sep 21, 2023

markmandel commented Sep 21, 2023

yoshd commented Sep 21, 2023 • edited Loading

agones-bot commented Sep 21, 2023

markmandel left a comment

Choose a reason for hiding this comment

google-oss-prow bot commented Sep 21, 2023

google-oss-prow bot commented Sep 21, 2023

agones-bot commented Sep 22, 2023

yoshd commented Sep 20, 2023 •

edited

Loading

yoshd commented Sep 21, 2023 •

edited

Loading