Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Node.Status.Address to GameServer.Status in CRD and SDK #3299

Merged
merged 7 commits into from
Aug 1, 2023
Merged

Add Node.Status.Address to GameServer.Status in CRD and SDK #3299

merged 7 commits into from
Aug 1, 2023

Conversation

zmerlynn
Copy link
Collaborator

@zmerlynn zmerlynn commented Aug 1, 2023 •
edited
Loading

Adds addresses to GameServer.Status and SDK reflection of same. Example:

  status:
    address: 34.69.11.29
    addresses:
    - address: 10.128.0.82
      type: InternalIP
    - address: 34.69.11.29
      type: ExternalIP
    - address: gk3-autogones-pool-2-b43ef98c-shdq
      type: Hostname

Towards #3089 (next step is to add to allocation APIs)

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 04774ce9-11a9-467a-b3ab-339fa3764eac

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 62b6b888-897b-474f-9c1f-90cd85dd93f8

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@zmerlynn zmerlynn requested review from gongmax and removed request for steven-supersolid and aLekSer August 1, 2023 19:47
@zmerlynn zmerlynn marked this pull request as ready for review August 1, 2023 19:47
@zmerlynn zmerlynn changed the title WIP: Add Node.Status.Address to GameServer.Status in CRD and SDK Add Node.Status.Address to GameServer.Status in CRD and SDK Aug 1, 2023
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: fa5c5b8d-8a87-4b37-be19-b572fe1206b4

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2c9056cc-30c3-49e2-8788-bb71b879b837

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3299/head:pr_3299 && git checkout pr_3299
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-6c4fda0-amd64

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, roberthbailey, zmerlynn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel
Copy link
Member

Only question: I assume doc updates will come later? (mostly just reference docs).

Otherwise, LGTM!

@zmerlynn
Copy link
Collaborator Author

zmerlynn commented Aug 1, 2023

Only question: I assume doc updates will come later? (mostly just reference docs).

Yup - two follow-on pieces (might be both in next PR)

  • Add to the allocation APIs
  • Add to docs

@google-oss-prow google-oss-prow bot removed the lgtm label Aug 1, 2023
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@zmerlynn zmerlynn enabled auto-merge (squash) August 1, 2023 21:58
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: ff4f7574-a060-4074-aed7-cb6a1b67e99e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c5dc3d66-d526-4a8e-ae2d-a2cca27cb32f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3299/head:pr_3299 && git checkout pr_3299
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-8ec6209-amd64

@zmerlynn zmerlynn merged commit 4d1086f into googleforgames:main Aug 1, 2023
2 checks passed
@zmerlynn zmerlynn mentioned this pull request Aug 2, 2023
Merged
@steven-supersolid
Copy link
Collaborator

Now we have types in the Node.js SDK we should also update the types. Once the local development server is ready I can put in a small PR for this. I'll check if we test every field returned and if so can add a check for the new field, but it may be overkill

@zmerlynn
Copy link
Collaborator Author

zmerlynn commented Aug 2, 2023

@steven-supersolid If it matters, #3307 expands the allocation API as well, so you might wait for that one. But yeah, #3301 was a "catch up" - we hadn't run gen-all-sdk-rpc in months, apparently!

@zmerlynn zmerlynn deleted the add-addresses-to-api branch August 2, 2023 13:23
@Kalaiselvi84 Kalaiselvi84 added kind/feature New features for Agones and removed kind/other labels Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@gongmax gongmax gongmax approved these changes

@EricFortin EricFortin Awaiting requested review from EricFortin

@steven-supersolid steven-supersolid Awaiting requested review from steven-supersolid

Assignees

@markmandel markmandel

@roberthbailey roberthbailey

@gongmax gongmax

Labels
approved kind/feature New features for Agones size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@zmerlynn @agones-bot @markmandel @steven-supersolid @roberthbailey @gongmax @Kalaiselvi84