Allocated GameServers updated on Fleet update #3101

markmandel · 2023-04-14T00:42:44Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it:

Functional implementation and testing of applying labels and/or annotations to any Allocated GameServers that are overflowed past the configured replica count.

Which issue(s) this PR fixes:

Work on #2682

Special notes for your reviewer:

Next ➡️ write some guides to close out the ticket.

agones-bot · 2023-04-14T01:00:21Z

Build Failed 😱

Build Id: 8ef68b27-c5e5-45cd-b863-4736f0ecf596

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-04-14T16:55:54Z

Build Failed 😱

Build Id: 1e12f288-8a7e-41f2-bf6d-f7099eceb1c6

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-04-14T17:57:53Z

Build Failed 😱

Build Id: b5d86899-2e39-4122-9211-f26b4632a0b8

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

zmerlynn · 2023-04-14T18:02:06Z

Step #24 - "submit-e2e-test-cloud-build": generic-1.25: Step #2 - "e2e-stable": Error: UPGRADE FAILED: Get "https://35.202.16.167/openapi/v2?timeout=32s": dial tcp 35.202.16.167:443: i/o timeout

huh.

agones-bot · 2023-04-14T19:17:50Z

Build Failed 😱

Build Id: 955130e5-56c2-4a51-ae61-f11f4db5d89c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-04-14T21:50:19Z

Build Succeeded 👏

Build Id: 8873d8ff-d184-40ba-b37c-b7a9ebe31254

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.32.0-f429ea5-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.32.0-f429ea5-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.32.0-f429ea5-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.32.0-f429ea5-amd64
Linux C++ SDK (build): agonessdk-1.32.0-f429ea5-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.32.0-f429ea5-amd64.zip

A preview of the website (the last 30 builds are retained):

https://f429ea5-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3101/head:pr_3101 && git checkout pr_3101
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-f429ea5-amd64

gongmax · 2023-04-14T22:28:52Z

examples/fleet.yaml

@@ -50,6 +50,17 @@ spec:
      maxSurge: 25%
      # the amount to decrements GameServers by. Defaults to 25%
      maxUnavailable: 25%
+  # [Stage:Alpha]
+  # [FeatureFlag:FleetAllocationOverflow]
+  # Labels and/or Annotations to apply to GameServers when the number of Allocated GameServers drops below


Should this be "Labels and/or Annotations to apply to GameServers when the number of the desired replicas on the underlying GameServerSet drops below the number of Allocated GameServers"?

You are right - I've got it backwards.

agones-bot · 2023-04-17T02:11:44Z

Build Succeeded 👏

Build Id: 94a0e3ee-cef5-481f-8ec3-92ea7877bee2

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.32.0-7c14c5a-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.32.0-7c14c5a-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.32.0-7c14c5a-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.32.0-7c14c5a-amd64
Linux C++ SDK (build): agonessdk-1.32.0-7c14c5a-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.32.0-7c14c5a-amd64.zip

A preview of the website (the last 30 builds are retained):

https://7c14c5a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3101/head:pr_3101 && git checkout pr_3101
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-7c14c5a-amd64

gongmax

LGTM

gongmax · 2023-04-21T21:23:48Z

pkg/gameserversets/allocation_overflow.go

+		return nil
+	}
+
+	rest = sortGameServersByStrategy(gsSet.Spec.Scheduling, rest, c.counter.Counts())


nit: shall we add some documentation about the sorting logic when picking up GameServers to add the overflow annotations/labels? Either in the design issue or somewhere on the website. I think it's kind of important for customer to be aware of, but right now it's not clear without looking into the code.

google-oss-prow · 2023-04-21T21:24:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow · 2023-04-21T21:24:15Z

New changes are detected. LGTM label has been removed.

agones-bot · 2023-04-21T21:34:34Z

Build Failed 😱

Build Id: e1a57c48-e51e-42fa-957d-ac7f046fc378

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-04-21T21:56:24Z

Build Failed 😱

Build Id: 9ee52662-420f-4917-8c85-1d8a6c994f95

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

gongmax · 2023-04-21T22:13:01Z

make[1]: *** [includes/website.mk:111: test-gen-api-docs] Error 1
make: *** [includes/website.mk:73: site-test] Error 2

markmandel · 2023-04-22T06:59:10Z

make[1]: *** [includes/website.mk:111: test-gen-api-docs] Error 1
make: *** [includes/website.mk:73: site-test] Error 2

Oops, looks like I missed something. I'll update.

Functional implementation and testing of applying labels and/or annotations to any `Allocated` `GameServers` that are overflowed past the configured replica count. Next ➡️ write some guides to close out the ticket. Work on googleforgames#2682

agones-bot · 2023-04-22T08:06:17Z

Build Succeeded 👏

Build Id: ba0c8f33-cf13-48af-b61d-950fa46f72fc

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.32.0-4760db7-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.32.0-4760db7-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.32.0-4760db7-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.32.0-4760db7-amd64
Linux C++ SDK (build): agonessdk-1.32.0-4760db7-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.32.0-4760db7-amd64.zip

A preview of the website (the last 30 builds are retained):

https://4760db7-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3101/head:pr_3101 && git checkout pr_3101
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-4760db7-amd64

markmandel requested review from zmerlynn, roberthbailey and gongmax April 14, 2023 00:42

google-oss-prow bot requested review from cyriltovena and EricFortin April 14, 2023 00:42

google-oss-prow bot added size/XL approved labels Apr 14, 2023

markmandel force-pushed the feature/allocationOverflow branch 2 times, most recently from cc58c14 to 37bb8b2 Compare April 14, 2023 00:53

markmandel force-pushed the feature/allocationOverflow branch from 71ffd15 to f429ea5 Compare April 14, 2023 17:24

gongmax reviewed Apr 14, 2023

View reviewed changes

google-oss-prow bot added size/XXL and removed size/XL labels Apr 17, 2023

gongmax approved these changes Apr 21, 2023

View reviewed changes

google-oss-prow bot assigned gongmax Apr 21, 2023

google-oss-prow bot added the lgtm label Apr 21, 2023

google-oss-prow bot removed the lgtm label Apr 21, 2023

markmandel added 2 commits April 22, 2023 09:04

Review updates.

4760db7

markmandel force-pushed the feature/allocationOverflow branch from 7f260ec to 4760db7 Compare April 22, 2023 07:07

markmandel merged commit 0fc3532 into googleforgames:main Apr 22, 2023

markmandel deleted the feature/allocationOverflow branch April 22, 2023 11:27

Kalaiselvi84 added the kind/feature New features for Agones label May 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allocated GameServers updated on Fleet update #3101

Allocated GameServers updated on Fleet update #3101

markmandel commented Apr 14, 2023

agones-bot commented Apr 14, 2023

agones-bot commented Apr 14, 2023

agones-bot commented Apr 14, 2023

zmerlynn commented Apr 14, 2023

agones-bot commented Apr 14, 2023

agones-bot commented Apr 14, 2023

gongmax Apr 14, 2023

markmandel Apr 17, 2023

agones-bot commented Apr 17, 2023

gongmax left a comment

gongmax Apr 21, 2023

google-oss-prow bot commented Apr 21, 2023

google-oss-prow bot commented Apr 21, 2023

agones-bot commented Apr 21, 2023

agones-bot commented Apr 21, 2023

gongmax commented Apr 21, 2023

markmandel commented Apr 22, 2023

agones-bot commented Apr 22, 2023

Allocated GameServers updated on Fleet update #3101

Allocated GameServers updated on Fleet update #3101

Conversation

markmandel commented Apr 14, 2023

agones-bot commented Apr 14, 2023

agones-bot commented Apr 14, 2023

agones-bot commented Apr 14, 2023

zmerlynn commented Apr 14, 2023

agones-bot commented Apr 14, 2023

agones-bot commented Apr 14, 2023

gongmax Apr 14, 2023

Choose a reason for hiding this comment

markmandel Apr 17, 2023

Choose a reason for hiding this comment

agones-bot commented Apr 17, 2023

gongmax left a comment

Choose a reason for hiding this comment

gongmax Apr 21, 2023

Choose a reason for hiding this comment

google-oss-prow bot commented Apr 21, 2023

google-oss-prow bot commented Apr 21, 2023

agones-bot commented Apr 21, 2023

agones-bot commented Apr 21, 2023

gongmax commented Apr 21, 2023

markmandel commented Apr 22, 2023

agones-bot commented Apr 22, 2023