Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop log level of worker queue to Trace #3092

Merged
merged 2 commits into from
Apr 14, 2023

Conversation

zmerlynn
Copy link
Collaborator

The "Enqueueing" logs in particular are pretty spammy, and the conflict log is a normal operation.

Keeps "Processing", which is also a bit spammy but does help delineate when the controller acted on a change.

@google-oss-prow google-oss-prow bot added the lgtm label Apr 13, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, zmerlynn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel enabled auto-merge (squash) April 13, 2023 00:36
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 98aee3f1-33f5-464f-842b-4e9e910f2a42

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3092/head:pr_3092 && git checkout pr_3092
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-09fa680-amd64

@google-oss-prow google-oss-prow bot removed the lgtm label Apr 13, 2023
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 0c6e1042-b860-4242-b70e-3ebc477634cc

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@zmerlynn
Copy link
Collaborator Author

zmerlynn commented Apr 13, 2023

Approvers: Leave this PR out of date. We're using it as a canary for @agones-bot auto-updating - next merge to main should tickle it. (This is a low priority PR.) (cc @gongmax who updated last)

The "Enqueueing" logs in particular are pretty spammy, and the
conflict log is a normal operation.

Keeps "Processing", which is also a bit spammy but does help delineate
when the controller acted on a change.
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 6d956096-a0ab-4bdc-8893-4dbd69c1874a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 386fe18a-3414-495a-9808-be4b29a860cd

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3092/head:pr_3092 && git checkout pr_3092
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-b400bc5-amd64

@markmandel markmandel merged commit 140e558 into googleforgames:main Apr 14, 2023
@Kalaiselvi84 Kalaiselvi84 added the kind/cleanup Refactoring code, fixing up documentation, etc label May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants