Adds Counter to SDK alpha.proto #3002

igooch · 2023-02-27T23:32:20Z

What type of PR is this?

/kind feature

What this PR does / Why we need it:

Adds Counter proto message and rpc methods to SDK alpha.proto as part of feature CountsAndLists.
Formats Counter proto message and rpc methods per Google AIP https://google.aip.dev/general guidance.
Stubs out counter methods in the SDK server and alpha_test.
Implements the Counter gRPC "get" and "update" in the LocalSDKServer.
Includes Google API protos needed for following the Google AIP guidance.
Includes generated SDK files for Golang and Swagger only.
Includes vendor fmutils for working with FieldMasks.

Which issue(s) this PR fixes:

Working on #2716

Special notes for your reviewer:

For localsdk_test I found that the testify/assert.Equal did not work for comparing two protos. This is a known issue for proto equality with testify (stretchr/testify#758), so we compare the protos with go-cmp/cmp.Diff (https://protobuf.dev/reference/go/faq/#deepequal).

A second note:
When implementing the localsdk I noted that the field of the protos are pointers. Fields as pointers were disabled in proto3 (golang/protobuf#15), so it appears that even thought the alpha.proto and other proto files use syntax = "proto3"; that the protos are somehow compiled as proto2.

agones-bot · 2023-03-02T17:04:02Z

Build Failed 😱

Build Id: 702c5b18-b35d-475d-aea4-85e828b11732

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-03-02T20:03:30Z

Build Failed 😱

Build Id: 0a2de46e-e932-4eb9-b8c6-47f4e718dc33

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-03-06T21:35:26Z

Build Failed 😱

Build Id: a753acc5-98f1-41b2-bbc8-eee9dd603075

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-03-06T23:21:55Z

Build Failed 😱

Build Id: 20c06ccc-16fe-47c1-8442-788da73362ff

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-03-06T23:32:56Z

Build Failed 😱

Build Id: 12179144-5603-4a22-adde-75d88fbe396d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

feature CountsAndLists. Formats Counter message and rpc methods per Google AIP https://google.aip.dev/general guidance. Stubs out counter methods in the SDK server and alpha_test. Implements the Counter gRPC get and update methods in the LocalSDKServer.

zmerlynn · 2023-03-20T17:14:01Z

I'm likely to be really slow this week but will review if I get a chance. If not, get another pass from @gongmax?

agones-bot · 2023-03-20T17:39:51Z

Build Succeeded 👏

Build Id: 82bc3e3d-1dfb-40d3-b0a9-4ec3f8c8cf01

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.31.0-753a075-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.31.0-753a075-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.31.0-753a075-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.31.0-753a075-amd64
Linux C++ SDK (build): agonessdk-1.31.0-753a075-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.31.0-753a075-amd64.zip

A preview of the website (the last 30 builds are retained):

https://753a075-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3002/head:pr_3002 && git checkout pr_3002
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-753a075-amd64

agones-bot · 2023-03-20T21:04:33Z

Build Succeeded 👏

Build Id: 28d3cdf2-b894-4c89-a8bc-78c60288f776

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.31.0-067b399-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.31.0-067b399-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.31.0-067b399-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.31.0-067b399-amd64
Linux C++ SDK (build): agonessdk-1.31.0-067b399-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.31.0-067b399-amd64.zip

A preview of the website (the last 30 builds are retained):

https://067b399-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3002/head:pr_3002 && git checkout pr_3002
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-067b399-amd64

pkg/sdkserver/localsdk.go

proto/sdk/alpha/alpha.proto

pkg/sdkserver/localsdk.go

agones-bot · 2023-03-21T22:31:15Z

Build Succeeded 👏

Build Id: ee73f7b8-8062-4048-9357-d14854972ba3

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.31.0-4455b83-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.31.0-4455b83-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.31.0-4455b83-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.31.0-4455b83-amd64
Linux C++ SDK (build): agonessdk-1.31.0-4455b83-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.31.0-4455b83-amd64.zip

A preview of the website (the last 30 builds are retained):

https://4455b83-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3002/head:pr_3002 && git checkout pr_3002
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-4455b83-amd64

zmerlynn

Thanks for the patience.

pkg/sdkserver/localsdk_test.go

google-oss-prow · 2023-03-22T06:02:32Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gongmax, igooch, zmerlynn
Once this PR has been reviewed and has the lgtm label, please assign ericfortin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow · 2023-03-22T16:04:19Z

New changes are detected. LGTM label has been removed.

agones-bot · 2023-03-22T16:10:56Z

Build Failed 😱

Build Id: 8a85ccb2-7927-4fb0-95f9-bdd0d08d2383

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-03-22T16:54:05Z

Build Failed 😱

Build Id: a0f198b3-ba29-4593-ac59-03bc6f9aefde

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-03-22T17:49:44Z

Build Succeeded 👏

Build Id: 6c426376-2371-409b-bf9b-edde2e3994cd

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.31.0-4d3498d-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.31.0-4d3498d-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.31.0-4d3498d-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.31.0-4d3498d-amd64
Linux C++ SDK (build): agonessdk-1.31.0-4d3498d-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.31.0-4d3498d-amd64.zip

A preview of the website (the last 30 builds are retained):

https://4d3498d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3002/head:pr_3002 && git checkout pr_3002
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-4d3498d-amd64

google-oss-prow bot added do-not-merge/work-in-progress size/L labels Feb 27, 2023

google-oss-prow bot requested review from cyriltovena and roberthbailey February 27, 2023 23:32

igooch force-pushed the arbitrary-counts-lists-2716 branch from a5ca1c1 to 7f91eba Compare February 28, 2023 17:37

google-oss-prow bot added size/M size/XL size/XXL and removed size/L size/M size/XL labels Feb 28, 2023

igooch force-pushed the arbitrary-counts-lists-2716 branch 3 times, most recently from 9b3f685 to bfb0965 Compare March 2, 2023 00:55

igooch force-pushed the arbitrary-counts-lists-2716 branch 2 times, most recently from e7b0cf8 to 425f225 Compare March 2, 2023 19:57

igooch force-pushed the arbitrary-counts-lists-2716 branch 4 times, most recently from 87e32ac to f73f5cf Compare March 6, 2023 21:29

igooch force-pushed the arbitrary-counts-lists-2716 branch 4 times, most recently from d068c63 to 05aee4c Compare March 6, 2023 23:15

igooch force-pushed the arbitrary-counts-lists-2716 branch from 05aee4c to b4f2d99 Compare March 6, 2023 23:26

google-oss-prow bot assigned zmerlynn Mar 10, 2023

igooch added 3 commits March 20, 2023 16:52

Adds Google API proto files for gRPC standard methods

8e447bd

Autogenerated files for Go SDK and adding fmutils

753a075

igooch force-pushed the arbitrary-counts-lists-2716 branch from 8323c59 to 753a075 Compare March 20, 2023 16:53

gongmax approved these changes Mar 21, 2023

View reviewed changes

pkg/sdkserver/localsdk.go Outdated Show resolved Hide resolved

pkg/sdkserver/localsdk.go Outdated Show resolved Hide resolved

proto/sdk/alpha/alpha.proto Show resolved Hide resolved

pkg/sdkserver/localsdk.go Show resolved Hide resolved

google-oss-prow bot assigned gongmax Mar 21, 2023

google-oss-prow bot added the lgtm label Mar 21, 2023

igooch force-pushed the arbitrary-counts-lists-2716 branch from 067b399 to cc8a4ee Compare March 21, 2023 21:19

google-oss-prow bot removed the lgtm label Mar 21, 2023

igooch force-pushed the arbitrary-counts-lists-2716 branch from cc8a4ee to 4455b83 Compare March 21, 2023 21:40

zmerlynn approved these changes Mar 22, 2023

View reviewed changes

pkg/sdkserver/localsdk_test.go Outdated Show resolved Hide resolved

pkg/sdkserver/localsdk_test.go Outdated Show resolved Hide resolved

google-oss-prow bot added the lgtm label Mar 22, 2023

igooch force-pushed the arbitrary-counts-lists-2716 branch from 4455b83 to 214494a Compare March 22, 2023 16:04

google-oss-prow bot removed the lgtm label Mar 22, 2023

Updates per reviewer comments

4d3498d

igooch force-pushed the arbitrary-counts-lists-2716 branch from 214494a to 4d3498d Compare March 22, 2023 16:23

gongmax merged commit 5ddbe60 into googleforgames:main Mar 22, 2023

Kalaiselvi84 added the kind/feature New features for Agones label Apr 10, 2023

Kalaiselvi84 added this to the 1.31.0 milestone Apr 10, 2023

igooch mentioned this pull request Jan 18, 2024

Request for igooch to become Approver #3600

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds Counter to SDK alpha.proto #3002

Adds Counter to SDK alpha.proto #3002

igooch commented Feb 27, 2023 •

edited

Loading

agones-bot commented Mar 2, 2023

agones-bot commented Mar 2, 2023

agones-bot commented Mar 6, 2023

agones-bot commented Mar 6, 2023

agones-bot commented Mar 6, 2023

zmerlynn commented Mar 20, 2023

agones-bot commented Mar 20, 2023

agones-bot commented Mar 20, 2023

agones-bot commented Mar 21, 2023

zmerlynn left a comment

google-oss-prow bot commented Mar 22, 2023

google-oss-prow bot commented Mar 22, 2023

agones-bot commented Mar 22, 2023

agones-bot commented Mar 22, 2023

agones-bot commented Mar 22, 2023

Adds Counter to SDK alpha.proto #3002

Adds Counter to SDK alpha.proto #3002

Conversation

igooch commented Feb 27, 2023 • edited Loading

agones-bot commented Mar 2, 2023

agones-bot commented Mar 2, 2023

agones-bot commented Mar 6, 2023

agones-bot commented Mar 6, 2023

agones-bot commented Mar 6, 2023

zmerlynn commented Mar 20, 2023

agones-bot commented Mar 20, 2023

agones-bot commented Mar 20, 2023

agones-bot commented Mar 21, 2023

zmerlynn left a comment

Choose a reason for hiding this comment

google-oss-prow bot commented Mar 22, 2023

google-oss-prow bot commented Mar 22, 2023

agones-bot commented Mar 22, 2023

agones-bot commented Mar 22, 2023

agones-bot commented Mar 22, 2023

igooch commented Feb 27, 2023 •

edited

Loading