Use containerd runtime based Windows image #2910

gongmax · 2023-01-18T06:24:39Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:
With Kubernetes 1.24, GKE no longer supports node images with the dockershim runtime, which includes windows_ltsc

Which issue(s) this PR fixes:

Closes #2582

Special notes for your reviewer:
Tested by run make gcloud-test-cluster with GCP_CLUSTER_NODEPOOL_WINDOWSINITIALNODECOUNT greater than 0 to create the Windows node pool

agones-bot · 2023-01-18T06:53:17Z

Build Succeeded 👏

Build Id: f1b8195e-c5fd-4eb4-92b2-50f158fe526f

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.29.0-139d6ca-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.29.0-139d6ca-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.29.0-139d6ca-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.29.0-139d6ca-amd64
Linux C++ SDK (build): agonessdk-1.29.0-139d6ca-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.29.0-139d6ca-amd64.zip

A preview of the website (the last 30 builds are retained):

https://139d6ca-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2910/head:pr_2910 && git checkout pr_2910
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.29.0-139d6ca-amd64

markmandel · 2023-01-18T18:15:27Z

I'm assuming we're just manually testing Agones with this containerd nodes for now? If so, I assume everything worked?

gongmax · 2023-01-18T18:20:43Z

I'm assuming we're just manually testing Agones with this containerd nodes for now? If so, I assume everything worked?

I only tested the windows node pool can be created with this image. Do you want me to test by running windows GameServers on these nodes? I don't think we have any e2e test covering windows GameServer.

markmandel · 2023-01-18T19:00:42Z

So I think there are two things to test:

Does the Agones sidecar images work on these nodes
Can you take an example, such as the Xonotic windows example, and see if that still works?

markmandel · 2023-01-19T19:07:24Z

Just to be extra clear - happy to approve this once we've done manual tests that work (or realise that everything is broken, and have a work stream to fix it).

agones-bot · 2023-01-27T01:52:33Z

Build Succeeded 👏

Build Id: 57f57065-6ea3-4c9d-b7c2-2eae5b3e43c5

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.29.0-139d6ca-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.29.0-139d6ca-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.29.0-139d6ca-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.29.0-139d6ca-amd64
Linux C++ SDK (build): agonessdk-1.29.0-139d6ca-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.29.0-139d6ca-amd64.zip

A preview of the website (the last 30 builds are retained):

https://139d6ca-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2910/head:pr_2910 && git checkout pr_2910
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.29.0-139d6ca-amd64

markmandel · 2023-01-31T23:07:20Z

Just checking in, see if we have done any manual tests on this?

gongmax · 2023-01-31T23:11:46Z

Hey Mark, sorry for the delay! I did some manual tests but the game server failed the health check. But the same issue also happens for the older Agones version (1.25) which support the k8s version that allows docker based windows image. I didn't get chance to look deeper into the health check failure yet.

gongmax · 2023-01-31T23:17:49Z

I can hold on this PR and put some effort to figure out why the example game server fails health check. Or we can merge this PR first to fix the not-working windows node pool template. Either way, I believe the example game server health check failure is a separate issue which already exists for a while.

markmandel · 2023-01-31T23:30:20Z

No worries on delay, just checking in!

Fun question - did the Agones sidecar fail to run? (I'm assuming not, because the health check failed?) if the sidecar ran, then I think we are good to merge this 👍🏻

gongmax · 2023-01-31T23:41:54Z

The container agones-gameserver-sidecar can actually start without any issue.

markmandel · 2023-01-31T23:48:54Z

Then unless anyone has objections, I concur with your earlier statement. Let's merge this, and return to the unhealthy game server issue at a later date 👍🏻 Sound good?

gongmax · 2023-01-31T23:49:54Z

SGTM

google-oss-prow · 2023-01-31T23:51:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow · 2023-01-31T23:52:06Z

New changes are detected. LGTM label has been removed.

markmandel · 2023-01-31T23:52:28Z

@gongmax can you please file an issue with the example windows game server failing? Since you have the most information 😄

gongmax · 2023-01-31T23:53:11Z

Sure, will do!

agones-bot · 2023-02-01T01:32:29Z

Build Failed 😱

Build Id: ecf2f928-8d32-4ec0-b19e-35a35ce9794b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-02-01T06:21:23Z

Build Succeeded 👏

Build Id: 87b68291-4630-4818-9f7d-4bdc81e60aad

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.30.0-972bc10-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.30.0-972bc10-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.30.0-972bc10-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.30.0-972bc10-amd64
Linux C++ SDK (build): agonessdk-1.30.0-972bc10-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.30.0-972bc10-amd64.zip

A preview of the website (the last 30 builds are retained):

https://972bc10-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2910/head:pr_2910 && git checkout pr_2910
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-972bc10-amd64

agones-bot · 2023-02-01T07:23:53Z

Build Succeeded 👏

Build Id: 59ffd149-f0de-4e35-9b9a-6feecf0ac206

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.30.0-a514774-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.30.0-a514774-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.30.0-a514774-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.30.0-a514774-amd64
Linux C++ SDK (build): agonessdk-1.30.0-a514774-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.30.0-a514774-amd64.zip

A preview of the website (the last 30 builds are retained):

https://a514774-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2910/head:pr_2910 && git checkout pr_2910
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-a514774-amd64

agones-bot · 2023-02-01T08:23:39Z

Build Succeeded 👏

Build Id: 9372fded-82fd-43a1-9f85-41d7f7839954

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.30.0-155cc81-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.30.0-155cc81-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.30.0-155cc81-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.30.0-155cc81-amd64
Linux C++ SDK (build): agonessdk-1.30.0-155cc81-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.30.0-155cc81-amd64.zip

A preview of the website (the last 30 builds are retained):

https://155cc81-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2910/head:pr_2910 && git checkout pr_2910
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-155cc81-amd64

Use containerd runtime based Windows image

139d6ca

google-oss-prow bot added the do-not-merge/work-in-progress label Jan 18, 2023

google-oss-prow bot requested review from cyriltovena and roberthbailey January 18, 2023 06:24

gongmax marked this pull request as ready for review January 18, 2023 06:24

google-oss-prow bot added size/XS and removed do-not-merge/work-in-progress labels Jan 18, 2023

gongmax requested review from markmandel and removed request for cyriltovena January 18, 2023 06:25

google-oss-prow bot requested a review from cyriltovena January 18, 2023 06:25

gongmax mentioned this pull request Jan 19, 2023

Upgrade windows node image on GKE #2582

Closed

roberthbailey assigned markmandel Jan 19, 2023

markmandel approved these changes Jan 31, 2023

View reviewed changes

google-oss-prow bot added the lgtm label Jan 31, 2023

google-oss-prow bot added the approved label Jan 31, 2023

markmandel enabled auto-merge (squash) January 31, 2023 23:51

Merge branch 'main' into windows_image

972bc10

google-oss-prow bot removed the lgtm label Jan 31, 2023

Merge branch 'main' into windows_image

a514774

Merge branch 'main' into windows_image

155cc81

markmandel merged commit fa32a31 into googleforgames:main Feb 1, 2023

Kalaiselvi84 added this to the 1.30.0 milestone Feb 28, 2023

Kalaiselvi84 added the area/tests Unit tests, e2e tests, anything to make sure things don't break label Feb 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use containerd runtime based Windows image #2910

Use containerd runtime based Windows image #2910

gongmax commented Jan 18, 2023

agones-bot commented Jan 18, 2023

markmandel commented Jan 18, 2023

gongmax commented Jan 18, 2023

markmandel commented Jan 18, 2023

markmandel commented Jan 19, 2023

agones-bot commented Jan 27, 2023

markmandel commented Jan 31, 2023

gongmax commented Jan 31, 2023 •

edited

Loading

gongmax commented Jan 31, 2023

markmandel commented Jan 31, 2023

gongmax commented Jan 31, 2023

markmandel commented Jan 31, 2023

gongmax commented Jan 31, 2023

google-oss-prow bot commented Jan 31, 2023

google-oss-prow bot commented Jan 31, 2023

markmandel commented Jan 31, 2023

gongmax commented Jan 31, 2023

agones-bot commented Feb 1, 2023

agones-bot commented Feb 1, 2023

agones-bot commented Feb 1, 2023

agones-bot commented Feb 1, 2023

Use containerd runtime based Windows image #2910

Use containerd runtime based Windows image #2910

Conversation

gongmax commented Jan 18, 2023

agones-bot commented Jan 18, 2023

markmandel commented Jan 18, 2023

gongmax commented Jan 18, 2023

markmandel commented Jan 18, 2023

markmandel commented Jan 19, 2023

agones-bot commented Jan 27, 2023

markmandel commented Jan 31, 2023

gongmax commented Jan 31, 2023 • edited Loading

gongmax commented Jan 31, 2023

markmandel commented Jan 31, 2023

gongmax commented Jan 31, 2023

markmandel commented Jan 31, 2023

gongmax commented Jan 31, 2023

google-oss-prow bot commented Jan 31, 2023

google-oss-prow bot commented Jan 31, 2023

markmandel commented Jan 31, 2023

gongmax commented Jan 31, 2023

agones-bot commented Feb 1, 2023

agones-bot commented Feb 1, 2023

agones-bot commented Feb 1, 2023

agones-bot commented Feb 1, 2023

gongmax commented Jan 31, 2023 •

edited

Loading