Update minikube instructions to 0.28.0

build/Makefile

@@ -329,7 +329,9 @@ clean-gcloud-config:
 # Use MINIKUBE_DRIVER variable to change the VM driver
 # (defaults virtualbox for Linux and macOS, hyperv for windows) if you so desire.
 minikube-test-cluster: ensure-build-image minikube-agones-profile
-	$(MINIKUBE) start --kubernetes-version v1.9.4 --vm-driver $(MINIKUBE_DRIVER) \
+	# localkube bootstrapper fixes issues with profiles
+	$(MINIKUBE) start --kubernetes-version v1.10.0 --vm-driver $(MINIKUBE_DRIVER) \
+		--bootstrapper=localkube \
 		--extra-config=apiserver.Admission.PluginNames=NamespaceLifecycle,LimitRanger,ServiceAccount,PersistentVolumeLabel,DefaultStorageClass,DefaultTolerationSeconds,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota \
 		--extra-config=apiserver.Authorization.Mode=RBAC
 	# wait until the master is up
@@ -340,8 +342,11 @@ minikube-test-cluster: ensure-build-image minikube-agones-profile
 		done
 	# this is needed for kubernetes component to work correctly while RBAC is enabled
 	-docker run --rm $(common_mounts) --network=host -v $(minikube_cert_mount) $(DOCKER_RUN_ARGS) $(build_tag) \
-		kubectl create clusterrolebinding add-on-cluster-admin --clusterrole=cluster-admin --serviceaccount=kube-system:default
-	docker run --rm $(common_mounts) --network=host -v $(minikube_cert_mount) $(DOCKER_RUN_ARGS) $(build_tag) helm init
+		kubectl create clusterrolebinding cluster-admin-binding --clusterrole=cluster-admin --serviceaccount=kube-system:default
+	docker run --rm $(common_mounts) --network=host -v $(minikube_cert_mount) $(DOCKER_RUN_ARGS) $(build_tag) \
+		kubectl apply -f $(mount_path)/build/helm.yaml
+	docker run --rm $(common_mounts) --network=host -v $(minikube_cert_mount) $(DOCKER_RUN_ARGS) $(build_tag) \
+		helm init --service-account helm
 	$(MAKE) minikube-post-start
 
 # switch to the agones cluster

build/README.md

@@ -67,12 +67,6 @@ as this makes it easy to create a (relatively) cross platform development and bu
 - (optional) Minikube will require [VirtualBox](https://www.virtualbox.org) and will need to be installed if you wish
   to develop on Minikube 
 
-This has currently yet to be tested, but should have few issues around testing, building and running on GKE.
-
-Issues with building and developing on Minikube are currently expected, due to lack of testing, but Agones will run on Minikube.  
-
-Testing on macOS and reporting bugs are appreciated.
-
 ## GOPATH
 
 This project should be cloned to the directory `$GOPATH/src/agones.dev/agones`
@@ -186,6 +180,9 @@ This will setup a [Minikube](https://github.com/kubernetes/minikube) cluster, ru
 Because Minikube runs on a virtualisation layer on the host, some of the standard build and development Make targets
 need to be replaced by Minikube specific targets.
 
+> We recommend installing version [0.28.0 of minikube](https://github.com/kubernetes/minikube/releases/tag/v0.28.0),
+due to issues with other versions
+
 First, [install Minikube](https://github.com/kubernetes/minikube#installation), which may also require you to install
 a virtualisation solution, such as [VirtualBox](https://www.virtualbox.org) as well.
 Check the [Building on Different Platforms](#building-on-different-platforms) above for details on what virtualisation 

install/README.md

@@ -149,9 +149,8 @@ a virtualisation solution, such as [VirtualBox][vb] as well.
 [minikube]: https://github.com/kubernetes/minikube#installation
 [vb]: https://www.virtualbox.org
 
-> Note: due to some [issues with the 0.26.x release](https://github.com/GoogleCloudPlatform/agones/issues/192),
-we recommend installing version [0.25.2 of minikube](https://github.com/kubernetes/minikube/releases/tag/v0.25.2)
-until they are resolved.
+> We recommend installing version [0.28.0 of minikube](https://github.com/kubernetes/minikube/releases/tag/v0.28.0),
+due to issues with other versions
 
 ## Creating an `agones` profile
 
@@ -167,11 +166,14 @@ The following command starts a local minikube cluster via virtualbox - but this
 replaced by a [vm-driver](https://github.com/kubernetes/minikube#requirements) of your choice.
 
 ```bash
-minikube start --kubernetes-version v1.9.4 --vm-driver virtualbox \
-  --extra-config=apiserver.Admission.PluginNames=NamespaceLifecycle,LimitRanger,ServiceAccount,PersistentVolumeLabel,DefaultStorageClass,DefaultTolerationSeconds,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota \
-  --extra-config=apiserver.Authorization.Mode=RBAC
+minikube start --kubernetes-version v1.10.0 --vm-driver virtualbox \
+    --bootstrapper=localkube \
+    --extra-config=apiserver.Admission.PluginNames=NamespaceLifecycle,LimitRanger,ServiceAccount,PersistentVolumeLabel,DefaultStorageClass,DefaultTolerationSeconds,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota \
+    --extra-config=apiserver.Authorization.Mode=RBAC
 ```
 
+> the --bootstrapper=localkube is required since we aren't using the `default` profile. ([bug](https://github.com/kubernetes/minikube/issues/2717))
+
 # Setting up an Azure Kubernetes Service (AKS) Cluster
 
 Follow these steps to create a cluster and install Agones directly on [Azure Kubernetes Service (AKS) ](https://docs.microsoft.com/azure/aks/).