Added list of various libs used in code #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Failed 😱 Build Id: 5e7b4126-74b2-4726-b419-3cfedfb1d7ca Build Logs |
|
Build Succeeded 👏 Build Id: 013895a4-40d7-48b4-9b24-33fce7966b37 The following development artifacts have been built, and will exist for the next 30 days:
|
markmandel
reviewed
Jun 20, 2018
build/README.md
Outdated
| - [pflag](https://github.com/spf13/pflag) | ||
| - [viper](https://github.com/spf13/viper) | ||
| - [grpc](https://godoc.org/google.golang.org/grpc) | ||
| - [context](https://golang.org/pkg/context/) |
There was a problem hiding this comment.
I feel like context is a core library in go, so it's probably not worth listing here.
Do we want to just list everything in here:
https://github.com/GoogleCloudPlatform/agones/blob/master/Gopkg.toml
(Or conversely, just point people to it?)
There was a problem hiding this comment.
A link for people unaware of dep's convention of using Gopkg.toml might be nice.
There was a problem hiding this comment.
TIL! As a newcomer to Go I didn't know about Gopkg.toml so thanks for the lesson!
Happy to take any approach you see fit.
There was a problem hiding this comment.
I don't have strong opinions on this one.
Maybe something like "This project uses dep (with link) as a dependency manager. You can see the list of dependencies here (link)"
That's probably the most valuable without having to (a) rewrite docs for another project (b) keep a list up to date in two places.
WDYT?
Have working instructions for running Kubernetes 1.10 on top of minikube 0.28.0 - including a workaround for non default profiles. Since Agones works fine on k8s 1.10, figured it was worth making the move.
Found a line here that makes no sense.
Keeping up with Kubernetes versions, as well as providing us the functionality to do SubResources. Also will enable tightening up of permissions re: googleforgames#150
|
Build Succeeded 👏 Build Id: 113abedd-7344-467b-b2d2-cbd36b71201f The following development artifacts have been built, and will exist for the next 30 days:
|
|
Build Failed 😱 Build Id: 0ff54c5a-0947-4f59-b87d-dd14e2cf684d Build Logs |
markmandel
approved these changes
Jul 3, 2018
markmandel
added
kind/documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen this practice in other open source git repos and find it rather useful so wanted to propose adding it :)
To me it serves two goals: