Fix minikube dev tooling #2662
Fix minikube dev tooling #2662
Conversation
The update to multi-arch images broke the minikube dev tooling, this fixes that. Only caveat being, that I can only test on amd64 architecture. In theory, it might work on a M1, but if not, we can switch our which images are loaded before being re-tagged based on host architecture.
markmandel
added
kind/bug
| @@ -28,7 +28,7 @@ minikube_cert_mount := ~/.minikube:$(HOME)/.minikube | |||
| # of the right version. | |||
| minikube-test-cluster: DOCKER_RUN_ARGS+=--network=host -v $(minikube_cert_mount) | |||
| minikube-test-cluster: $(ensure-build-image) | |||
| $(MINIKUBE) start --kubernetes-version v1.22.9 -p $(MINIKUBE_PROFILE) --vm-driver $(MINIKUBE_DRIVER) | |||
| $(MINIKUBE) start --kubernetes-version v1.22.9 -p $(MINIKUBE_PROFILE) --driver $(MINIKUBE_DRIVER) | |||
There was a problem hiding this comment.
Snuck in a change - vm-driver is deprecated.
|
FYI: @mridulji since you tested this last and found the issue 👍🏻 |
| $(MINIKUBE) image load $(ping_amd64_tag) -p $(MINIKUBE_PROFILE) | ||
| $(MINIKUBE) image load $(allocator_amd64_tag) -p $(MINIKUBE_PROFILE) | ||
|
|
||
| $(MINIKUBE) image tag $(sidecar_linux_amd64_tag) $(sidecar_tag) -p $(MINIKUBE_PROFILE) |
There was a problem hiding this comment.
As you noted, this seems likely to break if minikube is running on an ARM machine (e.g. an M1 mac).
There was a problem hiding this comment.
I've sent #2663 to update the docs so that this knowledge is more easily discoverable.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markmandel, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / Why we need it:
The update to multi-arch images broke the minikube dev tooling, this
fixes that.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
Only caveat being, that I can only test on amd64 architecture. In theory, it might work on a M1, but if not, we can switch our which
images are loaded before being re-tagged based on host architecture.