Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unblock CI: Fix site link 404 #2619

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix

What this PR does / Why we need it:

This website for generating a self-signed SSL certificate is down, and also our instructions have since changed, so I removed the link altogether.

Which issue(s) this PR fixes:

N/A, but unblocks CI.

Special notes for your reviewer:

N/A

This website for generating a self-signed SSL certificate is down, and
also our instructions have since changed, so I removed the link
altogether.
@markmandel markmandel added kind/documentation Documentation for Agones kind/cleanup Refactoring code, fixing up documentation, etc labels Jun 8, 2022
@markmandel markmandel added this to the 1.24.0 milestone Jun 8, 2022
@google-oss-prow google-oss-prow bot requested a review from dzlier-gcp June 8, 2022 19:07
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1cf100c9-53d8-4c9c-83a7-f5ef9ca6ea5d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2619/head:pr_2619 && git checkout pr_2619
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.24.0-f5cfa4b-amd64

@markmandel markmandel merged commit 4cf2f91 into googleforgames:main Jun 8, 2022
@markmandel markmandel deleted the site/404-cert-link branch June 8, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants