Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for reserved replicas metric #2611

Merged

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix

What this PR does / Why we need it:

Noticed there weren't docs for #2609, so here there are!

Which issue(s) this PR fixes:

Work on #2609

Special notes for your reviewer:

N/A

Noticed there weren't docs for googleforgames#2609, so here there are!
@markmandel markmandel added kind/feature New features for Agones kind/documentation Documentation for Agones labels Jun 6, 2022
@markmandel markmandel added this to the 1.24.0 milestone Jun 6, 2022
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: e45aaadd-8030-43bd-ae4f-1afd4955d651

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member Author

docker run --rm -e "GOOS=darwin" -e "GOARCH=arm64" -e "GO111MODULE=on" -w /go/src/agones.dev/agones -v /workspace/build//.config/gcloud:/root/.config/gcloud -v ~/.kube/:/root/.kube -v ~/.config/helm:/root/.config/helm -v ~/.cache/helm:/root/.cache/helm -v /workspace:/go/src/agones.dev/agones -v /workspace/build//.gomod:/go/pkg/mod -v /workspace/build//.gocache:/root/.cache/go-build agones-build:dea9705952 go build -mod=vendor \
	-o /go/src/agones.dev/agones/cmd/sdk-server/bin/sdk-server.darwin.arm64  -ldflags "-X agones.dev/agones/pkg.Version=1.24.0-0a3f465" agones.dev/agones/cmd/sdk-server
docker run --rm -e "GOOS=darwin" -e "GOARCH=arm64" -e "GO111MODULE=on" -w /go/src/agones.dev/agones -v /workspace/build//.config/gcloud:/root/.config/gcloud -v ~/.kube/:/root/.kube -v ~/.config/helm:/root/.config/helm -v ~/.cache/helm:/root/.cache/helm -v /workspace:/go/src/agones.dev/agones -v /workspace/build//.gomod:/go/pkg/mod -v /workspace/build//.gocache:/root/.cache/go-build agones-build:dea9705952 go build -mod=vendor \
	-o /go/src/agones.dev/agones/cmd/sdk-server/bin/sdk-server.darwin.arm64  -ldflags "-X agones.dev/agones/pkg.Version=1.24.0-0a3f465" agones.dev/agones/cmd/sdk-server

go build agones.dev/agones/cmd/sdk-server: build output "/go/src/agones.dev/agones/cmd/sdk-server/bin/sdk-server.darwin.arm64" already exists and is not an object file

Weird it gets called twice like that.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c8730251-5d2d-44b7-a399-ad070ca733cf

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2611/head:pr_2611 && git checkout pr_2611
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.24.0-0a3f465-amd64

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey merged commit 04b23b4 into googleforgames:main Jun 6, 2022
@govargo
Copy link
Contributor

govargo commented Jun 7, 2022

Thank you!
I'll catch up next.

@markmandel markmandel deleted the docs/reserved_metrics branch June 7, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/documentation Documentation for Agones kind/feature New features for Agones lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants