Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the new gke-gcloud-auth-plugin binary to the build image #2561

Merged

Conversation

roberthbailey
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it: Without this change, you can no longer fetch credentials for GKE clusters after running make shell, which also causes make gen-embedded-openapi to fail.

Which issue(s) this PR fixes:

Work on #2494

Special notes for your reviewer: See https://cloud.google.com/blog/products/containers-kubernetes/kubectl-auth-changes-in-gke

@google-oss-prow google-oss-prow bot added the lgtm label Apr 26, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pooneh-m, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pooneh-m,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 60cebd37-ee68-4794-8440-8729d058acad

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey
Copy link
Member Author

Flake:

--- FAIL: TestGameServerRestartBeforeReadyCrash (207.29s)
    gameserver_test.go:354: 
        	Error Trace:	gameserver_test.go:354
        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestGameServerRestartBeforeReadyCrash
FAIL

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a71ff3b0-98c1-405f-b38d-0c09f18fb785

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2561/head:pr_2561 && git checkout pr_2561
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.23.0-72110c4

@roberthbailey roberthbailey merged commit db917ca into googleforgames:main Apr 26, 2022
@SaitejaTamma SaitejaTamma added this to the 1.23.0 milestone May 3, 2022
@SaitejaTamma SaitejaTamma added the kind/feature New features for Agones label May 3, 2022
@roberthbailey roberthbailey added kind/cleanup Refactoring code, fixing up documentation, etc and removed kind/feature New features for Agones labels May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants