Queue updated GameServers with DeletionTimestamp #2550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe this closes the issue with Shutdown GameServer's very rarely getting stuck (very hard to test in an e2e test). Closes googleforgames#2360
markmandel
added
kind/bug
|
Build Succeeded 👏 Build Id: ec916e01-f4ea-4879-86bf-a883b3394132 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
roberthbailey
approved these changes
Apr 22, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markmandel, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thiryn
pushed a commit
to Thiryn/agones
that referenced
this pull request
Apr 25, 2022
I believe this closes the issue with Shutdown GameServer's very rarely getting stuck (very hard to test in an e2e test). Closes googleforgames#2360
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / Why we need it:
I believe this closes the issue with Shutdown GameServer's very rarely getting stuck (very hard to test in an e2e test).
Which issue(s) this PR fixes:
Closes #2360