sdk arm64 images #2521

Ludea · 2022-03-23T09:40:22Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it:
Build sdk image for arm64 hosts
Which issue(s) this PR fixes:

Work on #2216

Special notes for your reviewer:

agones-bot · 2022-03-23T09:49:26Z

Build Failed 😱

Build Id: 2cc6e0d9-8e2a-4516-a449-e671ecddd4d3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

build/Makefile

agones-bot · 2022-03-23T11:00:53Z

Build Failed 😱

Build Id: ab43d14e-ae52-4283-be99-4de83ed31dfa

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2022-03-23T11:18:46Z

Build Failed 😱

Build Id: c9c177f8-7c9c-47f6-a7a5-e24fa1ae013e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2022-03-23T11:29:26Z

Build Failed 😱

Build Id: aaccee7c-9a9f-404e-a0a8-0fb9c5ac22e2

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2022-03-23T11:34:55Z

Build Failed 😱

Build Id: 6dec9780-0290-4bef-ba34-864ff7c55c2f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2022-03-23T11:42:08Z

Build Failed 😱

Build Id: 364c0497-4255-4e24-b458-fd67880fea53

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2022-03-23T11:52:13Z

Build Failed 😱

Build Id: 497013b3-6fb7-489d-8d39-ce02c5969cac

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2022-03-23T11:59:24Z

Build Failed 😱

Build Id: af47c522-65c8-45f1-9796-fa8037e727e4

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2022-04-25T06:46:49Z

Build Succeeded 👏

Build Id: 2d2adb14-c839-4c10-a1a2-7f047353ba96

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.23.0-dae4c85
image: gcr.io/agones-images/agones-ping:1.23.0-dae4c85
Linux C++ SDK (build): agonessdk-1.23.0-dae4c85-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.23.0-dae4c85.zip

A preview of the website (the last 30 builds are retained):

https://dae4c85-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2521/head:pr_2521 && git checkout pr_2521
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.23.0-dae4c85

agones-bot · 2022-04-25T19:44:26Z

Build Succeeded 👏

Build Id: 9b7c62c8-5e26-4668-8591-04f09a815321

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.23.0-af45e9d
image: gcr.io/agones-images/agones-ping:1.23.0-af45e9d
Linux C++ SDK (build): agonessdk-1.23.0-af45e9d-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.23.0-af45e9d.zip

A preview of the website (the last 30 builds are retained):

https://af45e9d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2521/head:pr_2521 && git checkout pr_2521
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.23.0-af45e9d

agones-bot · 2022-04-26T03:53:01Z

Build Succeeded 👏

Build Id: 86dc4deb-9503-4809-82be-91b59c2212c8

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.23.0-3b1e6c4
image: gcr.io/agones-images/agones-ping:1.23.0-3b1e6c4
Linux C++ SDK (build): agonessdk-1.23.0-3b1e6c4-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.23.0-3b1e6c4.zip

A preview of the website (the last 30 builds are retained):

https://3b1e6c4-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2521/head:pr_2521 && git checkout pr_2521
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.23.0-3b1e6c4

agones-bot · 2022-04-26T08:11:00Z

Build Succeeded 👏

Build Id: 397a6b01-a539-4492-99c9-eddfde4a940f

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.23.0-ec06756
image: gcr.io/agones-images/agones-ping:1.23.0-ec06756
Linux C++ SDK (build): agonessdk-1.23.0-ec06756-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.23.0-ec06756.zip

A preview of the website (the last 30 builds are retained):

https://ec06756-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2521/head:pr_2521 && git checkout pr_2521
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.23.0-ec06756

agones-bot · 2022-04-26T18:48:10Z

Build Succeeded 👏

Build Id: 9882219d-0707-4369-b574-a8f832110bf6

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.23.0-7a0c947
image: gcr.io/agones-images/agones-ping:1.23.0-7a0c947
Linux C++ SDK (build): agonessdk-1.23.0-7a0c947-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.23.0-7a0c947.zip

A preview of the website (the last 30 builds are retained):

https://7a0c947-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2521/head:pr_2521 && git checkout pr_2521
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.23.0-7a0c947

agones-bot · 2022-04-27T06:00:57Z

Build Succeeded 👏

Build Id: 51d37b5e-ad57-4175-9fac-8b499fea19f4

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.23.0-6e2082d
image: gcr.io/agones-images/agones-ping:1.23.0-6e2082d
Linux C++ SDK (build): agonessdk-1.23.0-6e2082d-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.23.0-6e2082d.zip

A preview of the website (the last 30 builds are retained):

https://6e2082d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2521/head:pr_2521 && git checkout pr_2521
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.23.0-6e2082d

agones-bot · 2022-04-28T10:29:28Z

Build Failed 😱

Build Id: 563ac549-f435-4853-937a-5a4888f55de9

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2022-04-28T17:24:08Z

Build Succeeded 👏

Build Id: ab0405de-4a9d-4bee-80a1-b9d75d584508

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.23.0-09f19f8
image: gcr.io/agones-images/agones-ping:1.23.0-09f19f8
Linux C++ SDK (build): agonessdk-1.23.0-09f19f8-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.23.0-09f19f8.zip

A preview of the website (the last 30 builds are retained):

https://09f19f8-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2521/head:pr_2521 && git checkout pr_2521
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.23.0-09f19f8

build/Makefile

agones-bot · 2022-04-28T18:55:58Z

Build Succeeded 👏

Build Id: 142c67a1-f947-4325-9b24-319daaeff18c

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.23.0-01b960a
image: gcr.io/agones-images/agones-ping:1.23.0-01b960a
Linux C++ SDK (build): agonessdk-1.23.0-01b960a-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.23.0-01b960a.zip

A preview of the website (the last 30 builds are retained):

https://01b960a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2521/head:pr_2521 && git checkout pr_2521
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.23.0-01b960a

roberthbailey · 2022-04-29T19:02:58Z

build/Makefile

+push-agones-sdk-linux-image-arm64: $(ensure-build-image)
+	$(MAKE) DOCKER_BUILD_ARGS=--push build-agones-sdk-image-arm64
+
+push-agones-sdk-linux-image-amd64: $(ensure-build-image)


I believe that this should depend on build-agones-sdk-image-amd64 instead of having the build image. I tried running this target (having modified the name of the image locally so it wouldn't exist) and got an error:

make: *** [Makefile:521: push-agones-sdk-linux-image-amd64] Error 1

For some reason the arm and windows targets above didn't have this issue, and I'm not sure why (maybe because they use buildx?).

I tested this change locally and it had the desired effect.

I'm going to merge this PR as-is and will send a follow up PR to tweak this line.

google-oss-prow · 2022-04-29T20:25:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ludea, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Ludea added 3 commits March 23, 2022 10:32

Build both arm64 and amd64 sdk img

680f316

Use arch variable

0281ab4

Don't use --build-arg when building on amd64, it's the default value

a4b2b5c

google-oss-prow bot requested review from cyriltovena and pooneh-m March 23, 2022 09:40

google-oss-prow bot added the size/S label Mar 23, 2022

Ludea commented Mar 23, 2022

View reviewed changes

build/Makefile Outdated Show resolved Hide resolved

enable binfmt

2a94635

google-oss-prow bot added size/M and removed size/S labels Mar 23, 2022

try without quotes

1c4fa4c

debug

ba446c3

docker info

bc21738

try with DOCKER_BUILD_KIT=1 DOCKER_CLI_EXPERIMENTAL=enabled

00192de

Ludea added 2 commits March 23, 2022 12:49

use buildx into build-agones-sdk-image-arm64 step

2718501

don't setup binfmt

a568924

google-oss-prow bot added size/S and removed size/M labels Mar 23, 2022

Ludea added 3 commits March 23, 2022 12:59

revert to docker -version

c55df8c

create a new buildx instance

a16e560

delete amd64 tag

fd8f24e

google-oss-prow bot removed the size/S label Mar 23, 2022

Merge branch 'main' into arm_images

af45e9d

Merge branch 'main' into arm_images

3b1e6c4

Merge branch 'main' into arm_images

ec06756

Merge branch 'main' into arm_images

7a0c947

Merge branch 'main' into arm_images

6e2082d

Merge branch 'main' into arm_images

855d17d

Merge branch 'main' into arm_images

09f19f8

roberthbailey reviewed Apr 28, 2022

View reviewed changes

build/Makefile Outdated Show resolved Hide resolved

build/Makefile Show resolved Hide resolved

Remove comment

01b960a

roberthbailey reviewed Apr 29, 2022

View reviewed changes

roberthbailey approved these changes Apr 29, 2022

View reviewed changes

google-oss-prow bot assigned roberthbailey Apr 29, 2022

google-oss-prow bot added the lgtm label Apr 29, 2022

google-oss-prow bot added the approved label Apr 29, 2022

roberthbailey merged commit aed208d into googleforgames:main Apr 29, 2022

roberthbailey mentioned this pull request Apr 29, 2022

Update dependency for the push-agones-sdk-linux-image-amd64 target #2564

Merged

SaitejaTamma added this to the 1.23.0 milestone May 3, 2022

roberthbailey added the kind/feature New features for Agones label May 3, 2022

roberthbailey mentioned this pull request May 3, 2022

Release v1.23.0-rc #2567

Merged

govargo mentioned this pull request May 31, 2022

Fix build command: build-agones-sdk-image #2603

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sdk arm64 images #2521

sdk arm64 images #2521

Ludea commented Mar 23, 2022 •

edited by markmandel

Loading

agones-bot commented Mar 23, 2022

agones-bot commented Mar 23, 2022

agones-bot commented Mar 23, 2022

agones-bot commented Mar 23, 2022

agones-bot commented Mar 23, 2022

agones-bot commented Mar 23, 2022

agones-bot commented Mar 23, 2022

agones-bot commented Mar 23, 2022

agones-bot commented Apr 25, 2022

agones-bot commented Apr 25, 2022

agones-bot commented Apr 26, 2022

agones-bot commented Apr 26, 2022

agones-bot commented Apr 26, 2022

agones-bot commented Apr 27, 2022

agones-bot commented Apr 28, 2022

agones-bot commented Apr 28, 2022

agones-bot commented Apr 28, 2022

roberthbailey Apr 29, 2022

roberthbailey Apr 29, 2022

roberthbailey Apr 29, 2022

roberthbailey Apr 29, 2022

google-oss-prow bot commented Apr 29, 2022

sdk arm64 images #2521

sdk arm64 images #2521

Conversation

Ludea commented Mar 23, 2022 • edited by markmandel Loading

agones-bot commented Mar 23, 2022

agones-bot commented Mar 23, 2022

agones-bot commented Mar 23, 2022

agones-bot commented Mar 23, 2022

agones-bot commented Mar 23, 2022

agones-bot commented Mar 23, 2022

agones-bot commented Mar 23, 2022

agones-bot commented Mar 23, 2022

agones-bot commented Apr 25, 2022

agones-bot commented Apr 25, 2022

agones-bot commented Apr 26, 2022

agones-bot commented Apr 26, 2022

agones-bot commented Apr 26, 2022

agones-bot commented Apr 27, 2022

agones-bot commented Apr 28, 2022

agones-bot commented Apr 28, 2022

agones-bot commented Apr 28, 2022

roberthbailey Apr 29, 2022

Choose a reason for hiding this comment

roberthbailey Apr 29, 2022

Choose a reason for hiding this comment

roberthbailey Apr 29, 2022

Choose a reason for hiding this comment

roberthbailey Apr 29, 2022

Choose a reason for hiding this comment

google-oss-prow bot commented Apr 29, 2022

Ludea commented Mar 23, 2022 •

edited by markmandel

Loading