Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Allocator unit tests to better test module #2441

Merged
merged 2 commits into from
Jan 20, 2022
Merged

Move Allocator unit tests to better test module #2441

merged 2 commits into from
Jan 20, 2022

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Lots of the allocator tests where tied into the GameServerAllocation controller tests, when there was no actual need for that to be the case.

This refactor de-couples those tests from the controller to have better isolation in the testing, make it easier to create new tests, and make test discovery for the Allocator system easier.

Also added a few more tests for extra coverage, and cleaned up a few pieces here and there with the migration.

Which issue(s) this PR fixes:

Refactoring and cleanup I made while investigating #2282.

Special notes for your reviewer:

N/A

@markmandel
Move Allocator unit tests to better test module
da6e0d1 
Refactoring and cleanup I made while investigating googleforgames#2282.

Lots of the allocator tests where tied into the GameServerAllocation
controller tests, when there was no actual need for that to be the case.

This refactor de-couples those tests from the controller to have
better isolation in the testing, make it easier to create new tests, and
make test discovery for the Allocator system easier.

Also added a few more tests for extra coverage, and cleaned up a few
pieces here and there with the migration.
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/tests Unit tests, e2e tests, anything to make sure things don't break labels Jan 20, 2022
@markmandel markmandel requested review from pooneh-m and removed request for EricFortin January 20, 2022 19:01
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c39bb42e-9ec4-4e89-bbd0-2844ded80c5d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2441/head:pr_2441 && git checkout pr_2441
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.21.0-da6e0d1

@google-oss-prow google-oss-prow bot added the lgtm label Jan 20, 2022
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-prow google-oss-prow bot removed the lgtm label Jan 20, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b7f1bece-cc46-4636-aa8b-27c8c5698f15

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2441/head:pr_2441 && git checkout pr_2441
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.21.0-86aba69

@markmandel markmandel merged commit 84277fb into googleforgames:main Jan 20, 2022
@markmandel markmandel deleted the refactor/allocation-tests branch January 20, 2022 23:03
@markmandel markmandel added this to the 1.21.0 milestone Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@pooneh-m pooneh-m Awaiting requested review from pooneh-m

Assignees

@roberthbailey roberthbailey

Labels
approved area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc size/XXL
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
3 participants
@markmandel @agones-bot @roberthbailey