-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove node_name label from allocation metrics #2433
Remove node_name label from allocation metrics #2433
Conversation
/assign @pooneh-m |
Build Failed 😱 Build Id: 5331cb0e-71ac-495a-8970-c0700b87821c To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
One day we will resolve the flake in |
Oh nice, you did the grafana one too. I'll find some time to spin up the new dashboards and confirm, and we'll get this in the new release 👍🏻 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markmandel, yoshd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Had a look at the grafana dashboard, all looks good 👍🏻 |
Build Failed 😱 Build Id: 9fff4bf5-e228-4b6b-915c-f6e97eae53b2 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: 3558a321-a8a0-4190-bb5d-f0ed46d7b33d The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind breaking
What this PR does / Why we need it:
Remove the node_name label from agones_gameserver_allocations_duration.
Which issue(s) this PR fixes: #2424
Special notes for your reviewer:
This is the response before the /metrics API was fixed:
After:
The "Allocations rate per node" graph in the Grafana dashboard used to use the node_name label, but I removed it because I don't think this graph is very useful.