Update the minikube driver flag name (--vm-driver is deprecated)

[roberthbailey]

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

[agones-bot]

Build Failed 😱

Build Id: f8b786da-3da4-44d5-8fbd-a83539005ef7

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[roberthbailey]

Flake in e2e-feature-gates:

--- FAIL: TestFleetAutoscalerTLSWebhook (318.36s)
    framework.go:284: 
        	Error Trace:	framework.go:284
        	            				fleetautoscaler_test.go:709
        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestFleetAutoscalerTLSWebhook
        	Messages:   	error waiting for fleet condition on fleet: simple-fleet-p6v9r
FAIL

[agones-bot]

Build Failed 😱

Build Id: 645e772f-eda7-447a-9f05-50aee0e28d31

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[roberthbailey]

Another flake in e2e-feature gates:

--- FAIL: TestFleetAutoscalerTLSWebhook (317.10s)
    framework.go:284: 
        	Error Trace:	framework.go:284
        	            				fleetautoscaler_test.go:709
        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestFleetAutoscalerTLSWebhook
        	Messages:   	error waiting for fleet condition on fleet: simple-fleet-w698n
FAIL

[agones-bot]

Build Failed 😱

Build Id: 562cb5f9-f753-48fe-9316-3f51c50e904d

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[roberthbailey]

Flakes in e2e-feature-gates:

--- FAIL: TestAutoscalerBasicFunctions (356.34s)
    framework.go:284: 
        	Error Trace:	framework.go:284
        	            				fleetautoscaler_test.go:89
        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestAutoscalerBasicFunctions
        	Messages:   	error waiting for fleet condition on fleet: simple-fleet-8lwfq
...
--- FAIL: TestFleetAutoscalerTLSWebhook (315.91s)
    framework.go:284: 
        	Error Trace:	framework.go:284
        	            				fleetautoscaler_test.go:709
        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestFleetAutoscalerTLSWebhook
        	Messages:   	error waiting for fleet condition on fleet: simple-fleet-dl6gt
FAIL

[agones-bot]

Build Failed 😱

Build Id: 084ce7e6-fd32-4d0f-a9d2-786fc58ef5b5

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cindy52, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[roberthbailey]

More flaky tests in e2e-feature-gates.... :/

--- FAIL: TestAutoscalerStressCreate (336.59s)
    framework.go:284: 
        	Error Trace:	framework.go:284
        	            				fleetautoscaler_test.go:355
        	            				fleetautoscaler_test.go:363
        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestAutoscalerStressCreate
        	Messages:   	error waiting for fleet condition on fleet: simple-fleet-twt44
...
--- FAIL: TestAutoscalerBasicFunctions (328.17s)
    framework.go:284: 
        	Error Trace:	framework.go:284
        	            				fleetautoscaler_test.go:89
        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestAutoscalerBasicFunctions
        	Messages:   	error waiting for fleet condition on fleet: simple-fleet-s64ns
FAIL

[agones-bot]

Build Failed 😱

Build Id: 886043ea-5ed8-4c84-83f7-e95576f9dd1b

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[roberthbailey]

tests are now failing from the link checker:

  Get https://v1-18.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.18/: x509: certificate is valid for *.netlify.app, netlify.app, not v1-18.docs.kubernetes.io --- site/docs/faq/index.html --> https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.18/#containerport-v1-core

It looks like the 1.18 kubernetes docs are no longer being published. The 1.19 docs still appear to work.

[roberthbailey]

I've created a separate PR to fix the broken links: #2405

[google-oss-prow]

New changes are detected. LGTM label has been removed.

[agones-bot]

Build Succeeded 👏

Build Id: 28ca68a8-44dc-4260-8053-265bd47c4144

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.20.0-477238b
• image: gcr.io/agones-images/agones-ping:1.20.0-477238b
• Linux C++ SDK (build): agonessdk-1.20.0-477238b-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.20.0-477238b.zip

A preview of the website (the last 30 builds are retained):

• https://477238b-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/2399/head:pr_2399 && git checkout pr_2399
• helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.20.0-477238b