pre_delete_hook.yaml should support release namespace

[rayterrill]

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:
The helm cleanup hook currently doesnt support installation namespace, so it goes into the default namespace.

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[agones-bot]

Build Succeeded 👏

Build Id: 017fac43-d33e-437b-b255-c1ea9d0814d4

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.19.0-1e0c6fd
• image: gcr.io/agones-images/agones-ping:1.19.0-1e0c6fd
• Linux C++ SDK (build): agonessdk-1.19.0-1e0c6fd-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.19.0-1e0c6fd.zip

A preview of the website (the last 30 builds are retained):

• https://1e0c6fd-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/2342/head:pr_2342 && git checkout pr_2342
• helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.19.0-1e0c6fd

[agones-bot]

Build Succeeded 👏

Build Id: 1dc44ace-937c-4d0e-9f5a-f3dfae38d271

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.19.0-35f637b
• image: gcr.io/agones-images/agones-ping:1.19.0-35f637b
• Linux C++ SDK (build): agonessdk-1.19.0-35f637b-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.19.0-35f637b.zip

A preview of the website (the last 30 builds are retained):

• https://35f637b-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/2342/head:pr_2342 && git checkout pr_2342
• helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.19.0-35f637b

[roberthbailey]

@rayterrill - can you please sign the CLA?

[rayterrill]

@googlebot I signed it!

[markmandel]

LGTM. Any issues on your end @roberthbailey ?

[roberthbailey]

I'm not sure what this configmap / job do.

Are they meant to clean up any running game servers when you uninstall? If so, shouldn't the be configured to run in gameservers.namespaces (using a loop) instead of the release namespace (generally agones-system)? I would expect there not to be any game servers running in the same namespace as the system components.

Or do they clean up the agones system components? In which case putting them into the release namespace does make sense.

[markmandel]

That is actually a really good point. I thought it deleted Agones components, but it actually deletes all GameServer and related.

You can see the script it runs here:
https://github.com/googleforgames/agones/blob/main/install/helm/agones/scripts/delete_agones_resources.sh

So there are actually a few problems we should solve:

Moving this into the release namespace is likely going to mean it's not going to delete anything, since it won't find any of the GameServers in the release namespace (I'm assuming that is where it will run).

So, we should either:

1. Have an instance of this in each namespace there might be gameservers
2. Edit the script to find and delete all GameServers across --all-namespaces (in which case running it under the .Release.Namespace is nicer because it's in the namespace, and it works as intended.

Thoughts?

[roberthbailey]

Looking lower in the helm template (hidden by default in the diff) it looks like we pass the gameservers.namespaces to the script, and the script iterates over the passed in namespaces and deletes resources in all of them. This actually seems a bit better than using --all-namespaces since it will only delete things in the namespaces configured in helm (providing more control / flexibility).

So this change will implement your second suggestion - moving the job and configmap into the agones-system namespace - which seems like a great improvement.

[google-oss-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rayterrill, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[google-oss-robot]

New changes are detected. LGTM label has been removed.

[roberthbailey]

As an aside I did also verify that kubectl delete gs --all --all-namespaces works to delete the game servers in multiple namespaces, so we could change the script to do that if we'd prefer. Either way, we should move both of these resources into the agones-system namespace.

[agones-bot]

Build Failed 😱

Build Id: fc1d9917-3824-44ec-8c2e-f6394a2dc2db

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Succeeded 👏

Build Id: 3a44d172-4a84-42b9-a726-2773ac8ff905

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.19.0-d69cb8a
• image: gcr.io/agones-images/agones-ping:1.19.0-d69cb8a
• Linux C++ SDK (build): agonessdk-1.19.0-d69cb8a-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.19.0-d69cb8a.zip

A preview of the website (the last 30 builds are retained):

• https://d69cb8a-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/2342/head:pr_2342 && git checkout pr_2342
• helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.19.0-d69cb8a