GKE installation wording tweaks #2322

karenarialin · 2021-10-19T23:16:11Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind documentation

What this PR does / Why we need it:
Minor clarifications

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

agones-bot · 2021-10-19T23:43:41Z

Build Succeeded 👏

Build Id: 60e8cc1a-b79c-4df1-a92a-56cb49485950

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.19.0-9221f8f
image: gcr.io/agones-images/agones-ping:1.19.0-9221f8f
Linux C++ SDK (build): agonessdk-1.19.0-9221f8f-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.19.0-9221f8f.zip

A preview of the website (the last 30 builds are retained):

https://9221f8f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2322/head:pr_2322 && git checkout pr_2322
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.19.0-9221f8f

roberthbailey

Thanks for the fixes. I just had one comment and one question.

site/content/en/docs/Installation/Creating Cluster/gke.md

agones-bot · 2021-10-25T19:19:26Z

Build Failed 😱

Build Id: 5d95611d-5e2b-49b8-a6d1-7d6c5556e678

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

roberthbailey · 2021-10-26T18:09:32Z

Test flake:

--- FAIL: TestGameServerReadyAllocateReady (47.37s)
    gameserver_test.go:508: 
        	Error Trace:	gameserver_test.go:508
        	Error:      	Received unexpected error:
        	            	read udp 192.168.10.7:49972->35.230.123.25:7920: i/o timeout
        	Test:       	TestGameServerReadyAllocateReady
        	Messages:   	Could not message GameServer

google-oss-robot · 2021-10-26T18:32:01Z

New changes are detected. LGTM label has been removed.

google-oss-robot · 2021-10-26T18:32:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karenarialin, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

agones-bot · 2021-10-26T19:06:52Z

Build Failed 😱

Build Id: 189d8360-9339-48c5-8766-aabec8f9dbae

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

roberthbailey · 2021-10-27T19:43:59Z

--- FAIL: TestFleetRecreateGameServers (0.00s)
    --- FAIL: TestFleetRecreateGameServers/gameserver_unhealthy (84.27s)
        fleet_test.go:1172: Could not message GameServer: read udp 192.168.10.2:39249->35.230.77.80:7830: i/o timeout

agones-bot · 2021-10-27T23:47:24Z

Build Failed 😱

Build Id: 8a37a7be-5ad2-42b3-bf33-7cf2d180ea56

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

roberthbailey · 2021-10-28T19:16:02Z

Flake:

--- FAIL: TestFleetAggregatedPlayerStatus (113.84s)
    fleet_test.go:1337: Could not message GameServer: read udp 192.168.10.3:51289->35.247.94.25:7030: i/o timeout

agones-bot · 2021-10-28T19:40:53Z

Build Failed 😱

Build Id: 4d080fb0-9629-49ea-8da9-ceb508ea4ea3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

roberthbailey · 2021-10-28T20:03:39Z

Another flake:

time="2021-10-28 19:40:26.269" level=info msg="error waiting for fleet condition" error="timed out waiting for the condition" fleet=simple-fleet-m5dpf test=TestAutoscalerBasicFunctions
--- FAIL: TestAutoscalerBasicFunctions (357.65s)
    fleetautoscaler_test.go:88: error waiting for fleet condition on fleet simple-fleet-m5dpf
FAIL

agones-bot · 2021-10-28T20:27:03Z

Build Failed 😱

Build Id: 97e8991f-84e7-49d6-92bc-e2e3aa9fa86a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

roberthbailey · 2021-10-28T20:31:50Z

Similar flake:

time="2021-10-28 20:26:37.038" level=info msg="error waiting for fleet condition" error="timed out waiting for the condition" fleet=simple-fleet-cnnj5 test=TestFleetAutoScalerRollingUpdate
--- FAIL: TestFleetAutoScalerRollingUpdate (331.80s)
    fleetautoscaler_test.go:231: error waiting for fleet condition on fleet simple-fleet-cnnj5
FAIL

agones-bot · 2021-10-28T20:59:46Z

Build Failed 😱

Build Id: bc250b47-747e-4d4a-8881-6712bf3d571c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

roberthbailey · 2021-10-29T07:33:14Z

Last run was another flake:

--- FAIL: TestFleetRecreateGameServers (0.00s)
    --- FAIL: TestFleetRecreateGameServers/gameserver_unhealthy (89.04s)
        fleet_test.go:1172: Could not message GameServer: read udp 192.168.10.2:55697->34.127.24.242:7625: i/o timeout

agones-bot · 2021-10-29T07:51:01Z

Build Failed 😱

Build Id: fb2be67f-dc88-4f4e-afcd-643b20270cad

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

roberthbailey · 2021-10-29T08:03:37Z

--- FAIL: TestFleetAutoscalerTLSWebhook (332.76s)
    framework.go:757: 
        	Error Trace:	framework.go:757
        	            				framework.go:315
        	            				framework.go:285
        	            				fleetautoscaler_test.go:708
        	Error:      	Received unexpected error:
        	            	won't be able to find any events of namespace 'default' in namespace '1635493248'
        	Test:       	TestFleetAutoscalerTLSWebhook

agones-bot · 2021-10-29T08:31:24Z

Build Failed 😱

Build Id: 340b2e90-04c6-4da0-8505-331865e5d0e9

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

roberthbailey · 2021-10-29T08:33:44Z

Step #21 - "e2e-feature-gates": --- FAIL: TestGameServerReserve (48.50s)
Step #21 - "e2e-feature-gates":     gameserver_test.go:628: 
Step #21 - "e2e-feature-gates":         	Error Trace:	gameserver_test.go:628
Step #21 - "e2e-feature-gates":         	Error:      	Could not message GameServer
Step #21 - "e2e-feature-gates":         	Test:       	TestGameServerReserve
Step #21 - "e2e-feature-gates":         	Messages:   	read udp 192.168.10.3:35684->35.199.170.79:7760: i/o timeout

agones-bot · 2021-10-29T09:03:05Z

Build Succeeded 👏

Build Id: 05ed8493-40bb-408d-93d2-15d3dd549ef4

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.19.0-bfb9821
image: gcr.io/agones-images/agones-ping:1.19.0-bfb9821
Linux C++ SDK (build): agonessdk-1.19.0-bfb9821-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.19.0-bfb9821.zip

A preview of the website (the last 30 builds are retained):

https://bfb9821-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2322/head:pr_2322 && git checkout pr_2322
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.19.0-bfb9821

GKE installation wording tweaks

9221f8f

google-oss-robot requested review from dzlier-gcp and EricFortin October 19, 2021 23:16

google-cla bot added the cla: yes label Oct 19, 2021

google-oss-robot added the size/S label Oct 19, 2021

roberthbailey reviewed Oct 20, 2021

View reviewed changes

site/content/en/docs/Installation/Creating Cluster/gke.md Outdated Show resolved Hide resolved

site/content/en/docs/Installation/Creating Cluster/gke.md Show resolved Hide resolved

Wording tweak

dfad90c

roberthbailey approved these changes Oct 26, 2021

View reviewed changes

google-oss-robot assigned roberthbailey Oct 26, 2021

google-oss-robot added the lgtm label Oct 26, 2021

Merge branch 'main' into patch-1

6614067

google-oss-robot removed the lgtm label Oct 26, 2021

google-oss-robot added the approved label Oct 26, 2021

Merge branch 'main' into patch-1

9dfb69a

Merge branch 'main' into patch-1

bfb9821

roberthbailey merged commit af4db07 into googleforgames:main Oct 29, 2021

karenarialin deleted the patch-1 branch October 29, 2021 16:51

roberthbailey added this to the 1.19.0 milestone Nov 1, 2021

SaitejaTamma added the kind/documentation Documentation for Agones label Nov 16, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GKE installation wording tweaks #2322

GKE installation wording tweaks #2322

karenarialin commented Oct 19, 2021

agones-bot commented Oct 19, 2021

roberthbailey left a comment

agones-bot commented Oct 25, 2021

roberthbailey commented Oct 26, 2021

google-oss-robot commented Oct 26, 2021

google-oss-robot commented Oct 26, 2021

agones-bot commented Oct 26, 2021

roberthbailey commented Oct 27, 2021

agones-bot commented Oct 27, 2021

roberthbailey commented Oct 28, 2021 •

edited

Loading

agones-bot commented Oct 28, 2021

roberthbailey commented Oct 28, 2021

agones-bot commented Oct 28, 2021

roberthbailey commented Oct 28, 2021

agones-bot commented Oct 28, 2021

roberthbailey commented Oct 29, 2021

agones-bot commented Oct 29, 2021

roberthbailey commented Oct 29, 2021

agones-bot commented Oct 29, 2021

roberthbailey commented Oct 29, 2021

agones-bot commented Oct 29, 2021

GKE installation wording tweaks #2322

GKE installation wording tweaks #2322

Conversation

karenarialin commented Oct 19, 2021

agones-bot commented Oct 19, 2021

roberthbailey left a comment

Choose a reason for hiding this comment

agones-bot commented Oct 25, 2021

roberthbailey commented Oct 26, 2021

google-oss-robot commented Oct 26, 2021

google-oss-robot commented Oct 26, 2021

agones-bot commented Oct 26, 2021

roberthbailey commented Oct 27, 2021

agones-bot commented Oct 27, 2021

roberthbailey commented Oct 28, 2021 • edited Loading

agones-bot commented Oct 28, 2021

roberthbailey commented Oct 28, 2021

agones-bot commented Oct 28, 2021

roberthbailey commented Oct 28, 2021

agones-bot commented Oct 28, 2021

roberthbailey commented Oct 29, 2021

agones-bot commented Oct 29, 2021

roberthbailey commented Oct 29, 2021

agones-bot commented Oct 29, 2021

roberthbailey commented Oct 29, 2021

agones-bot commented Oct 29, 2021

roberthbailey commented Oct 28, 2021 •

edited

Loading