Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore SDK CPP build directory #2284

Merged
merged 2 commits into from
Sep 30, 2021

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

test/sdk/cpp/sdk/ gets generated on CPP SDK testing, but depending on your dev path, may not get cleaned up (and you may not want it to be cleaned up).

So finally adding it to .gitignore rather than forcing myself to delete it every time.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

test/sdk/cpp/sdk/ gets generated on CPP SDK testing, but depending on
your dev path, may not get cleaned up (and you may not want it to be
cleaned up).

So finally adding it to .gitignore rather than forcing myself to delete
it every time.
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. labels Sep 30, 2021
@google-cla google-cla bot added the cla: yes label Sep 30, 2021
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 48f05d33-b3c2-4ea9-9da2-9a3503a0e4d4

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2284/head:pr_2284 && git checkout pr_2284
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.18.0-7670b6e

@markmandel markmandel merged commit 1b74ae7 into googleforgames:main Sep 30, 2021
@markmandel markmandel deleted the cleanup/ignore-cpp-dir branch September 30, 2021 21:32
@markmandel markmandel added this to the 1.18.0 milestone Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. cla: yes kind/cleanup Refactoring code, fixing up documentation, etc size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants