Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: High Density Integration Pattern #2270

Merged
merged 3 commits into from
Sep 24, 2021

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix

What this PR does / Why we need it:

Documentation explaining how to use the new advanced allocation features to run multiple concurrent game sessions in a single GameServer instance.

Which issue(s) this PR fixes:

Closes #1239

Special notes for your reviewer:

This is tricky to explain, because it is a little complicated. All feedback appreciated to try and explain this concept!

If you have thoughts on if there are improvements / better ways to explain, please add them to this PR 👍🏻

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 3ca829cf-3029-4d79-ac9a-3262827ee67f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: d8f000e7-9cc4-423a-bd12-2900785545f9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2270/head:pr_2270 && git checkout pr_2270
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.18.0-d23d739

@markmandel
Copy link
Member Author

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 0ac661f1-d74f-4629-893d-ec62911991e4

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2270/head:pr_2270 && git checkout pr_2270
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.18.0-2ad4e07

@markmandel
Copy link
Member Author

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ee262ef0-cb48-4f38-9991-f34e6fecabd9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2270/head:pr_2270 && git checkout pr_2270
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.18.0-f8e90eb

Documentation explaining how to use the new advanced allocation features
to run multiple concurrent game sessions in a single `GameServer`
instance.

Closes googleforgames#1239
@markmandel
Copy link
Member Author

Updated! I think this should be good to go now!

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2ff5200b-c3b5-4a18-89e0-da21a1c875d1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2270/head:pr_2270 && git checkout pr_2270
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.18.0-c1a2130

Copy link
Member

@roberthbailey roberthbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a minor typo and have one last grammatical suggestion.

systems, since it works around the common Kubernetes and/or Agones container lifecycle.

Utilising the new allocation `gameServerState` filter as well as the existing ability to edit the
`GameServer` Labels at both [allocation time]({{% ref "/docs/Reference/gameserverallocation.md" %}}), and from
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Labels should be lowercase as it is in the middle of a sentence.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

end alt
note right
If the <i>GameServer</i> can accept
more concurrent sessions, reset the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: reset the label

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4237d65d-33f2-40bd-a5d3-b1c93e681c23

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2270/head:pr_2270 && git checkout pr_2270
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.18.0-29dd542

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 3f3517b4-be53-4995-b999-d9155f4c6159

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2270/head:pr_2270 && git checkout pr_2270
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.18.0-1d11f5f

@roberthbailey roberthbailey merged commit b77874b into googleforgames:main Sep 24, 2021
@markmandel markmandel deleted the docs/high-density branch September 29, 2021 18:57
@roberthbailey roberthbailey added this to the 1.18.0 milestone Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Game Server Allocation advanced filtering: player count, state, reallocation
4 participants