-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate the Helm value for the allocator service name from its service account name #2268
Separate the Helm value for the allocator service name from its service account name #2268
Conversation
Build Failed 😱 Build Id: 33d05f0a-3266-4f73-ad19-126d2c1eafe2 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
I'm all for making the names separate, but can you do something like
instead, since that will align with how we are planning to restructure the service configs in #2263? |
For sure. This was actually my first reaction to making the change, but didn't see nested scope on any of the other variables. Will update accordingly. |
Build Failed 😱 Build Id: dc6e7b0a-dcc7-4253-9c02-143fd188c9f4 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Looks like a test flake. Can you rebase on main and re-push your branch? (I can't update your branch for you) |
@@ -174,9 +174,10 @@ The following tables lists the configurable parameters of the Agones chart and t | |||
| `agones.allocator.annotations` | [Annotations][annotations] added to the Agones allocator pods | `{}` | | |||
| `agones.allocator.resources` | Allocator pods [resource requests/limit][resources] | `{}` | | |||
| `agones.allocator.nodeSelector` | Allocator [node labels][nodeSelector] for pod assignment | `{}` | | |||
| `agones.allocator.service.name` | Service name for the allocator | `agones-allocator` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the new field, please add it to the table below (line 192) so that it doesn't appear in the docs until the next release. Thanks!
Build Succeeded 👏 Build Id: d72733a5-6fde-43b3-be2c-9770f34d46ec The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rcreasey, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / Why we need it:
Separates the allocation service name from allocation service account name during a helm installation. There are instances where I want to use the default
agones-allocator
service account name, yet customize the actual service name. Additionally, should the service account name require updates, this will also impact the allocation service name (which could cause breaking changes to workloads depending on that fqdn).