Clone Kubernetes objects in API Server before encoding them #2089

highlyunavailable · 2021-05-01T18:22:00Z

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

This works around a race condition present in the encoder for Kubernetes objects, as detailed in kubernetes #82497.

Which issue(s) this PR fixes:
Closes #2086

Special notes for your reviewer:

An shallow copy is used here instead of a mutex since that is the suggested fix in the Kubernetes PR and I'd rather align with their fix strategy. I've checked for use of this in other places in Agones, but this is the only place we use this specific encoder.

highlyunavailable · 2021-05-01T18:36:29Z

Random suspicion: I believe this comment may have been a symptom of this bug:

// not testing for version/kind, seems not to come through. Strange.
// we're not building anything that needs this, so not our issue.

agones-bot · 2021-05-01T18:47:46Z

Build Succeeded 👏

Build Id: 027a12ac-9fc5-41e6-8a1d-8178a3e43971

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.14.0-47d331f
image: gcr.io/agones-images/agones-ping:1.14.0-47d331f
Linux C++ SDK (build): agonessdk-1.14.0-47d331f-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.14.0-47d331f.zip

A preview of the website (the last 30 builds are retained):

https://47d331f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2089/head:pr_2089 && git checkout pr_2089
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.14.0-47d331f

agones-bot · 2021-05-01T19:01:05Z

Build Succeeded 👏

Build Id: 93d6e184-0598-4f0d-b8a7-2e55d5d7dc82

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.14.0-8a2ecfe
image: gcr.io/agones-images/agones-ping:1.14.0-8a2ecfe
Linux C++ SDK (build): agonessdk-1.14.0-8a2ecfe-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.14.0-8a2ecfe.zip

A preview of the website (the last 30 builds are retained):

https://8a2ecfe-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2089/head:pr_2089 && git checkout pr_2089
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.14.0-8a2ecfe

agones-bot · 2021-05-01T19:13:06Z

Build Succeeded 👏

Build Id: 1b5aa5d6-8447-4cb5-8b1b-de645e10be64

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.15.0-734f0c4
image: gcr.io/agones-images/agones-ping:1.15.0-734f0c4
Linux C++ SDK (build): agonessdk-1.15.0-734f0c4-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.15.0-734f0c4.zip

A preview of the website (the last 30 builds are retained):

https://734f0c4-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2089/head:pr_2089 && git checkout pr_2089
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.15.0-734f0c4

agones-bot · 2021-05-01T19:20:26Z

Build Failed 😱

Build Id: 3c6206ac-e599-4945-a6ac-b61bc5554931

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2021-05-01T19:20:32Z

Build Failed 😱

Build Id: 3c6206ac-e599-4945-a6ac-b61bc5554931

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2021-05-01T19:32:49Z

Build Succeeded 👏

Build Id: fa930db5-e079-48ce-95fa-9ba6fc9bc3da

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.15.0-599645a
image: gcr.io/agones-images/agones-ping:1.15.0-599645a
Linux C++ SDK (build): agonessdk-1.15.0-599645a-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.15.0-599645a.zip

A preview of the website (the last 30 builds are retained):

https://599645a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2089/head:pr_2089 && git checkout pr_2089
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.15.0-599645a

agones-bot · 2021-05-01T19:54:17Z

Build Succeeded 👏

Build Id: fb311c16-4edd-4c53-9b0e-31e851cd8be5

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.15.0-53a2d98
image: gcr.io/agones-images/agones-ping:1.15.0-53a2d98
Linux C++ SDK (build): agonessdk-1.15.0-53a2d98-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.15.0-53a2d98.zip

A preview of the website (the last 30 builds are retained):

https://53a2d98-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2089/head:pr_2089 && git checkout pr_2089
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.15.0-53a2d98

pkg/util/apiserver/apiserver.go

This works around a race condition present in the encoder for Kubernetes objects, as detailed in kubernetes/kubernetes#82497 Uses the fix from kubernetes/kubernetes#101123 Fixes googleforgames#2086

google-oss-robot · 2021-05-03T16:29:47Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: highlyunavailable, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

agones-bot · 2021-05-03T16:46:37Z

Build Succeeded 👏

Build Id: 2b194e37-a1fd-4d2b-ad0d-23ee4f24b393

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.15.0-136ba05
image: gcr.io/agones-images/agones-ping:1.15.0-136ba05
Linux C++ SDK (build): agonessdk-1.15.0-136ba05-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.15.0-136ba05.zip

A preview of the website (the last 30 builds are retained):

https://136ba05-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2089/head:pr_2089 && git checkout pr_2089
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.15.0-136ba05

google-cla bot added the cla: yes label May 1, 2021

google-oss-robot requested review from pooneh-m and roberthbailey May 1, 2021 18:22

google-oss-robot added the size/L label May 1, 2021

highlyunavailable force-pushed the copy-object-before-encode branch 2 times, most recently from 8a2ecfe to 734f0c4 Compare May 1, 2021 18:35

highlyunavailable force-pushed the copy-object-before-encode branch from 734f0c4 to 599645a Compare May 1, 2021 18:38

highlyunavailable force-pushed the copy-object-before-encode branch from 599645a to 8876ee8 Compare May 1, 2021 18:56

highlyunavailable force-pushed the copy-object-before-encode branch from 8876ee8 to 53a2d98 Compare May 1, 2021 19:27

google-oss-robot added size/M and removed size/L labels May 1, 2021

roberthbailey reviewed May 3, 2021

View reviewed changes

pkg/util/apiserver/apiserver.go Outdated Show resolved Hide resolved

Shallow copy Kubernetes objects in API Server before encoding them

136ba05

This works around a race condition present in the encoder for Kubernetes objects, as detailed in kubernetes/kubernetes#82497 Uses the fix from kubernetes/kubernetes#101123 Fixes googleforgames#2086

highlyunavailable force-pushed the copy-object-before-encode branch from 53a2d98 to 136ba05 Compare May 3, 2021 16:19

highlyunavailable requested a review from roberthbailey May 3, 2021 16:19

roberthbailey approved these changes May 3, 2021

View reviewed changes

google-oss-robot assigned roberthbailey May 3, 2021

google-oss-robot added the lgtm label May 3, 2021

google-oss-robot added the approved label May 3, 2021

roberthbailey merged commit db3a1b4 into googleforgames:main May 3, 2021

sawagh added this to the 1.15.0 milestone Jun 1, 2021

sawagh added area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/bug These are bugs. labels Jun 1, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clone Kubernetes objects in API Server before encoding them #2089

Clone Kubernetes objects in API Server before encoding them #2089

highlyunavailable commented May 1, 2021 •

edited

Loading

highlyunavailable commented May 1, 2021

agones-bot commented May 1, 2021

agones-bot commented May 1, 2021

agones-bot commented May 1, 2021

agones-bot commented May 1, 2021

agones-bot commented May 1, 2021

agones-bot commented May 1, 2021

agones-bot commented May 1, 2021

google-oss-robot commented May 3, 2021

agones-bot commented May 3, 2021

Clone Kubernetes objects in API Server before encoding them #2089

Clone Kubernetes objects in API Server before encoding them #2089

Conversation

highlyunavailable commented May 1, 2021 • edited Loading

highlyunavailable commented May 1, 2021

agones-bot commented May 1, 2021

agones-bot commented May 1, 2021

agones-bot commented May 1, 2021

agones-bot commented May 1, 2021

agones-bot commented May 1, 2021

agones-bot commented May 1, 2021

agones-bot commented May 1, 2021

google-oss-robot commented May 3, 2021

agones-bot commented May 3, 2021

highlyunavailable commented May 1, 2021 •

edited

Loading