Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for running windows game servers #2065

Merged
merged 2 commits into from
Apr 20, 2021

Conversation

roberthbailey
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix

What this PR does / Why we need it: Applies updates to #2047 that @jeremyje didn't have time to make in the hope of getting it submitted prior to the release candidate.

Which issue(s) this PR fixes:
Part of #54

Special notes for your reviewer: Supersedes #2047.

@roberthbailey
Copy link
Member Author

@jeremyje - I know you said you didn't have time to finish #2047, but if you have a few minutes to take a look at this PR I'd appreciate it.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 971fd3d4-e8c4-492b-b236-86c7b27c317c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@jeremyje
Copy link
Contributor

/lgtm

@google-oss-robot
Copy link

@jeremyje: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 6ab639df-2497-45ee-9050-2084a9538788

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2065/head:pr_2065 && git checkout pr_2065
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.14.0-431dbef

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2d4b8895-285d-47f8-ab0f-52eb59b6f3d6

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2065/head:pr_2065 && git checkout pr_2065
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.14.0-cd8d01f

Copy link
Contributor

@pooneh-m pooneh-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the docs. I rely on @jeremyje 's LGTM for windows :)

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, pooneh-m, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,pooneh-m,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey merged commit 730ab22 into googleforgames:main Apr 20, 2021
@roberthbailey roberthbailey added this to the 1.14.0 milestone Apr 20, 2021
@roberthbailey roberthbailey added kind/documentation Documentation for Agones area/operations Installation, updating, metrics etc area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Apr 20, 2021
@roberthbailey roberthbailey deleted the windows-docs branch September 23, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/operations Installation, updating, metrics etc area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc cla: yes kind/documentation Documentation for Agones lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants