Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump lodash from 4.17.15 to 4.17.19 in /sdks/nodejs #1706

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 21, 2020

Bumps lodash from 4.17.15 to 4.17.19.

Release notes

Sourced from lodash's releases.

4.17.16

Commits
Maintainer changes

This version was pushed to npm by mathias, a new releaser for lodash since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.15...4.17.19)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the area/security Issues pertaining to security label Jul 21, 2020
@roberthbailey
Copy link
Member

@steven-supersolid - I created this by clicking a button in github, but I'm not sure it does what we want or is sufficient. There is a vulnerability in versions prior to 4.17.19 so we want to update to that version

When I search through package-lock.json, I see lots of references to lodash (at multiple versions). So the fact that dependabot is only updating the version in one place seems suspicious.

Can you take a look?

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 86437a32-d4d5-4432-b351-1796bbb3e624

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@steven-supersolid
Copy link
Collaborator

It looks fine because while the version of lodash required by other dependencies did not change, e.g. @babel/core requires ^4.17.13, the top level dependency did change and fulfils this (4.17.x)

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dependabot[bot], steven-supersolid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey
Copy link
Member

The build failed on deploy-site-static:

ERROR: (gcloud.app.deploy) ABORTED: Cannot operate on apps/agones-images/services/preview/versions/c41af21 because an operation is already in progress for apps/agones-images/services/preview/versions/c41af21 by 0eec883e-087d-4cfe-9086-31b869074679.ERROR: (gcloud.app.deploy) ABORTED: Cannot operate on apps/agones-images/services/preview/versions/c41af21 because an operation is already in progress for apps/agones-images/services/preview/versions/c41af21 by 0eec883e-087d-4cfe-9086-31b869074679.

Copy link
Member

@roberthbailey roberthbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/close

@@ -1,6 +1,6 @@
{
"name": "@google-cloud/agones-sdk",
"version": "1.7.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want this part changed. Since I don't think this is editable, I'm going to close this and manually open a PR.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 21, 2020

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/sdks/nodejs/lodash-4.17.19 branch July 21, 2020 18:02
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 0d5df0a2-0d32-422d-9554-950e1e42c59e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1706/head:pr_1706 && git checkout pr_1706
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-c41af21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants