Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Hugo and Docsy #1671

Merged
merged 1 commit into from
Jul 6, 2020
Merged

Update Hugo and Docsy #1671

merged 1 commit into from
Jul 6, 2020

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Due to #1668, saw that Hugo can fall over with:
fatal error: concurrent map read and map write

When there are lots of CPUs, so decided it was time to take the
opportunity to update Hugo.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Only big difference was to enable "unsafe" in the markdown engine, so that it would allow HTML in markdown.

@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/site The website itself - including redirects, styling, search, etc labels Jul 1, 2020
roberthbailey
roberthbailey approved these changes Jul 1, 2020
View reviewed changes
site/config.toml Outdated
angledQuotes = false
latexDashes = true
[markup.goldmark.renderer]
unsafe= true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: space before = sign?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah, that's ugly. I'll fix that up. Copy paste from stack overflow issue!

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 309abcd0-31a2-444f-9365-d788910ca592

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1671/head:pr_1671 && git checkout pr_1671
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-5ec0bff

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: d31724bd-f51c-4cee-9b4f-f1bcf0af0e93

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1671/head:pr_1671 && git checkout pr_1671
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-44a9c3b

@markmandel
Update Hugo and Docsy
ed5e42c 
Due to googleforgames#1668, saw that Hugo can fall over with:
`fatal error: concurrent map read and map write`

When there are lots of CPUs, so decided it was time to take the
opportunity to update Hugo.

Only big difference was to enable "unsafe" in the markdown engine, so
that it would allow HTML in markdown.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 63890c40-eb51-44bc-a916-d18a2f3272e5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1671/head:pr_1671 && git checkout pr_1671
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-ed5e42c

@markmandel markmandel merged commit f3723b0 into googleforgames:master Jul 6, 2020
@markmandel markmandel added this to the 1.7.0 milestone Jul 6, 2020
@markmandel markmandel deleted the update/hugo branch July 29, 2020 19:37
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@markmandel @ilkercelikyilmaz
Update Hugo and Docsy (googleforgames#1671)
84e7668 
Due to googleforgames#1668, saw that Hugo can fall over with:
`fatal error: concurrent map read and map write`

When there are lots of CPUs, so decided it was time to take the
opportunity to update Hugo.

Only big difference was to enable "unsafe" in the markdown engine, so
that it would allow HTML in markdown.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@EricFortin EricFortin Awaiting requested review from EricFortin

@pooneh-m pooneh-m Awaiting requested review from pooneh-m

Assignees

@roberthbailey roberthbailey

Labels
approved area/site The website itself - including redirects, styling, search, etc cla: yes kind/cleanup Refactoring code, fixing up documentation, etc size/XL
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
5 participants
@markmandel @agones-bot @google-oss-robot @roberthbailey @googlebot