New feature: SDK cached gameserver #1642

akremsa · 2020-06-23T20:29:56Z

What type of PR is this?

/kind feature

What this PR does / Why we need it:
Return GS immediately after WatchGameServer is called. Long discussion here.

Which issue(s) this PR fixes:

Closes #1630

Special notes for your reviewer:
Should feature-stages.md be also updated?

agones-bot · 2020-06-23T20:51:43Z

Build Succeeded 👏

Build Id: 9bf305fd-9b00-49b9-90de-e8e3ae60dfdd

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.7.0-aac59b5
image: gcr.io/agones-images/agones-sdk:1.7.0-aac59b5
image: gcr.io/agones-images/agones-ping:1.7.0-aac59b5
Linux C++ SDK (build): agonessdk-1.7.0-aac59b5-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.7.0-aac59b5.zip

A preview of the website (the last 30 builds are retained):

https://aac59b5-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1642/head:pr_1642 && git checkout pr_1642
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-aac59b5

aLekSer

Please add an update to the documentation. https://agones.dev/site/docs/guides/feature-stages/#feature-gates
You could also update this document https://agones.dev/site/docs/guides/client-sdks/#watchgameserver-function-gameserver and link to above one.

akremsa · 2020-06-24T13:13:46Z

Please add an update to the documentation. https://agones.dev/site/docs/guides/feature-stages/#feature-gates

That is what I was asking, thanks.

agones-bot · 2020-06-24T15:44:04Z

Build Failed 😱

Build Id: 2af634ee-9657-46eb-afe4-424c58ba374d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-06-24T15:55:47Z

Build Failed 😱

Build Id: 25f47b3e-bc7e-464a-a1e4-693ed6698d9f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-06-24T16:38:10Z

Build Failed 😱

Build Id: 7e4224f6-a6cd-4d2a-ad39-43ceaa58c7bd

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

pkg/sdkserver/sdkserver.go

pkg/sdkserver/sdkserver_test.go

build/Makefile

site/content/en/docs/Guides/Client SDKs/_index.md

akremsa · 2020-06-26T13:44:53Z

PR is updated taking into account the comments above. Please check.

agones-bot · 2020-06-26T13:54:43Z

Build Succeeded 👏

Build Id: d05fdb9d-32b2-413b-b4b5-a7775d19a668

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.7.0-639472c
image: gcr.io/agones-images/agones-sdk:1.7.0-639472c
image: gcr.io/agones-images/agones-ping:1.7.0-639472c
Linux C++ SDK (build): agonessdk-1.7.0-639472c-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.7.0-639472c.zip

A preview of the website (the last 30 builds are retained):

https://639472c-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1642/head:pr_1642 && git checkout pr_1642
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-639472c

agones-bot · 2020-06-26T14:00:18Z

Build Succeeded 👏

Build Id: b13f55f9-17ab-4ac3-9f9a-9b186cf614b1

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.7.0-6d3bd5c
image: gcr.io/agones-images/agones-sdk:1.7.0-6d3bd5c
image: gcr.io/agones-images/agones-ping:1.7.0-6d3bd5c
Linux C++ SDK (build): agonessdk-1.7.0-6d3bd5c-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.7.0-6d3bd5c.zip

A preview of the website (the last 30 builds are retained):

https://6d3bd5c-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1642/head:pr_1642 && git checkout pr_1642
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-6d3bd5c

agones-bot · 2020-06-26T14:05:53Z

Build Failed 😱

Build Id: 85e57143-7ca4-457b-a27c-c3eb7f1bfebe

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-06-26T14:29:36Z

Build Failed 😱

Build Id: b71666b4-5c1e-40c9-b38f-2375888b0113

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel

Almost there I feel!

pkg/util/runtime/features.go

site/content/en/docs/Guides/feature-stages.md

pkg/sdkserver/sdkserver.go

akremsa · 2020-06-29T14:41:27Z

@markmandel done

agones-bot · 2020-06-29T14:49:52Z

Build Failed 😱

Build Id: 07c76732-dbaf-49f2-873e-175ef3751c2e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-06-29T15:03:25Z

Build Failed 😱

Build Id: f3ef75c4-f3d4-4b29-ad46-f16024c61571

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

fix

agones-bot · 2020-06-29T16:08:17Z

Build Failed 😱

Build Id: 06f088f6-3d41-4d05-9d73-0c6e15c447fa

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2020-06-29T16:33:33Z

Are you rebased against master?

We did just move to Helm 3.

akremsa · 2020-06-29T16:35:08Z

Yes, latest master ...

markmandel · 2020-06-29T16:35:10Z

Yep, looks like you have. Weird. Investigating.

markmandel · 2020-06-29T16:36:09Z

Ah found it. Residual Helm 2 installation.

markmandel

Nice! Glad to get this in for this release!

agones-bot · 2020-06-29T17:02:56Z

Build Succeeded 👏

Build Id: e16f9a77-3817-4f81-8806-8494d3aee798

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.7.0-fbaadef
image: gcr.io/agones-images/agones-sdk:1.7.0-fbaadef
image: gcr.io/agones-images/agones-ping:1.7.0-fbaadef
Linux C++ SDK (build): agonessdk-1.7.0-fbaadef-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.7.0-fbaadef.zip

A preview of the website (the last 30 builds are retained):

https://fbaadef-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1642/head:pr_1642 && git checkout pr_1642
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-fbaadef

markmandel · 2020-06-29T17:15:39Z

@aLekSer need you to approve, so we can merge 😄

aLekSer

Helped a bit with the test. Approving the code.

google-oss-robot · 2020-06-29T17:46:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akremsa, aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot · 2020-06-29T18:04:54Z

New changes are detected. LGTM label has been removed.

agones-bot · 2020-06-29T18:36:53Z

Build Succeeded 👏

Build Id: d9cbb98b-f958-4108-a680-d9795aaacf60

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.7.0-1b7fc0b
image: gcr.io/agones-images/agones-sdk:1.7.0-1b7fc0b
image: gcr.io/agones-images/agones-ping:1.7.0-1b7fc0b
Linux C++ SDK (build): agonessdk-1.7.0-1b7fc0b-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.7.0-1b7fc0b.zip

A preview of the website (the last 30 builds are retained):

https://1b7fc0b-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1642/head:pr_1642 && git checkout pr_1642
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-1b7fc0b

* introduced FeatureGameServerCaching feature Co-authored-by: Mark Mandel <markmandel@google.com>

googlebot added the cla: yes label Jun 23, 2020

google-oss-robot added the size/M label Jun 23, 2020

google-oss-robot requested review from cyriltovena and EricFortin June 23, 2020 20:30

aLekSer suggested changes Jun 24, 2020

View reviewed changes

google-oss-robot assigned aLekSer Jun 24, 2020

akremsa force-pushed the cached-gs-feature branch from 4a04067 to d225eab Compare June 24, 2020 15:24

akremsa requested a review from aLekSer June 24, 2020 15:53

akremsa force-pushed the cached-gs-feature branch from d225eab to 7d0ece6 Compare June 24, 2020 16:17

markmandel reviewed Jun 24, 2020

View reviewed changes

akremsa force-pushed the cached-gs-feature branch from 7d0ece6 to 6d3bd5c Compare June 26, 2020 13:27

akremsa force-pushed the cached-gs-feature branch from 061ae30 to 21af786 Compare June 26, 2020 14:07

markmandel reviewed Jun 26, 2020

View reviewed changes

alexey-kremsa-globant added 7 commits June 29, 2020 17:37

introduced FeatureGameServerCaching feature

001b69d

added GS cache logic to sdkserver

2842eb4

Turn GameServerCaching on as an alpha feature

d848dc3

added FeatureGameServerCaching unit test

a0583dc

Added GameServerCaching description to site docs

f5859ed

Renamed feature GameServerCaching to SDKWatchSendOnExecute

b04294a

added SDKWatchSendOnExecute to cloudbuild.yaml

128d1bc

akremsa force-pushed the cached-gs-feature branch from 21af786 to f268ad4 Compare June 29, 2020 14:39

akremsa force-pushed the cached-gs-feature branch from f268ad4 to 5abdbae Compare June 29, 2020 14:53

removed cachedGameServer field and method, updated unit test

fbaadef

fix

akremsa force-pushed the cached-gs-feature branch from 5abdbae to fbaadef Compare June 29, 2020 15:58

markmandel approved these changes Jun 29, 2020

View reviewed changes

google-oss-robot assigned markmandel Jun 29, 2020

google-oss-robot added lgtm approved labels Jun 29, 2020

aLekSer approved these changes Jun 29, 2020

View reviewed changes

Merge branch 'master' into cached-gs-feature

1b7fc0b

google-oss-robot removed the lgtm label Jun 29, 2020

markmandel merged commit a666be8 into googleforgames:master Jun 29, 2020

markmandel added area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones labels Jun 29, 2020

markmandel added this to the 1.7.0 milestone Jun 29, 2020

ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020

New feature: SDK cached gameserver (googleforgames#1642)

6ffa36a

* introduced FeatureGameServerCaching feature Co-authored-by: Mark Mandel <markmandel@google.com>

aLekSer mentioned this pull request Dec 14, 2020

Utilize ExternalDNS as well as ExternalIP #1928

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New feature: SDK cached gameserver #1642

New feature: SDK cached gameserver #1642

akremsa commented Jun 23, 2020

agones-bot commented Jun 23, 2020

aLekSer left a comment •

edited

Loading

akremsa commented Jun 24, 2020

agones-bot commented Jun 24, 2020

agones-bot commented Jun 24, 2020

agones-bot commented Jun 24, 2020

akremsa commented Jun 26, 2020

agones-bot commented Jun 26, 2020

agones-bot commented Jun 26, 2020

agones-bot commented Jun 26, 2020

agones-bot commented Jun 26, 2020

markmandel left a comment

akremsa commented Jun 29, 2020

agones-bot commented Jun 29, 2020

agones-bot commented Jun 29, 2020

agones-bot commented Jun 29, 2020

markmandel commented Jun 29, 2020

akremsa commented Jun 29, 2020

markmandel commented Jun 29, 2020

markmandel commented Jun 29, 2020

markmandel left a comment

agones-bot commented Jun 29, 2020

markmandel commented Jun 29, 2020

aLekSer left a comment

google-oss-robot commented Jun 29, 2020

google-oss-robot commented Jun 29, 2020

agones-bot commented Jun 29, 2020

New feature: SDK cached gameserver #1642

New feature: SDK cached gameserver #1642

Conversation

akremsa commented Jun 23, 2020

agones-bot commented Jun 23, 2020

aLekSer left a comment • edited Loading

Choose a reason for hiding this comment

akremsa commented Jun 24, 2020

agones-bot commented Jun 24, 2020

agones-bot commented Jun 24, 2020

agones-bot commented Jun 24, 2020

akremsa commented Jun 26, 2020

agones-bot commented Jun 26, 2020

agones-bot commented Jun 26, 2020

agones-bot commented Jun 26, 2020

agones-bot commented Jun 26, 2020

markmandel left a comment

Choose a reason for hiding this comment

akremsa commented Jun 29, 2020

agones-bot commented Jun 29, 2020

agones-bot commented Jun 29, 2020

agones-bot commented Jun 29, 2020

markmandel commented Jun 29, 2020

akremsa commented Jun 29, 2020

markmandel commented Jun 29, 2020

markmandel commented Jun 29, 2020

markmandel left a comment

Choose a reason for hiding this comment

agones-bot commented Jun 29, 2020

markmandel commented Jun 29, 2020

aLekSer left a comment

Choose a reason for hiding this comment

google-oss-robot commented Jun 29, 2020

google-oss-robot commented Jun 29, 2020

agones-bot commented Jun 29, 2020

aLekSer left a comment •

edited

Loading