Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

factored metrics logic out of the allocator main file #1512

Merged
merged 1 commit into from
May 4, 2020

Conversation

pooneh-m
Copy link
Contributor

@pooneh-m pooneh-m commented May 4, 2020

What type of PR is this?
/kind cleanup

What this PR does / Why we need it:
Moved metrics related code out of agones-allocator main.go to its owns separate file.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 3806eddf-57a8-4219-8c8f-951732ec6fea

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1512/head:pr_1512 && git checkout pr_1512
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-2cb6393

Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyriltovena, pooneh-m

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cyriltovena,pooneh-m]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pooneh-m pooneh-m merged commit 3e10a67 into googleforgames:master May 4, 2020
@markmandel markmandel added this to the 1.6.0 milestone May 19, 2020
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label May 19, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants