Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added log_level parameter to Terraform deployment #1438

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

akremsa
Copy link
Contributor

@akremsa akremsa commented Mar 30, 2020

Added log_level parameter to Terraform deployment
There is a debug default value in makefile, but info in terraform configs.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c0a46772-1bb2-4b78-9dbd-c55d50481830

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1438/head:pr_1438 && git checkout pr_1438
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-4044015

@@ -41,6 +42,7 @@ endif
-var name=$(GCP_TF_CLUSTER_NAME) -var machine_type="$(GCP_CLUSTER_NODEPOOL_MACHINETYPE)" \
-var values_file="" \
-var zone="$(GCP_CLUSTER_ZONE)" -var project="$(GCP_PROJECT)" \
-var log_level="$(LOG_LEVEL)" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@markmandel markmandel added the area/operations Installation, updating, metrics etc label Mar 30, 2020
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akremsa, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel added this to the 1.5.0 milestone Mar 30, 2020
@markmandel markmandel merged commit 154e7fe into googleforgames:master Mar 30, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/operations Installation, updating, metrics etc lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants