Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add go.sum to SuperTuxKart example. #1434

Merged
merged 2 commits into from
Mar 31, 2020
Merged

Add go.sum to SuperTuxKart example. #1434

merged 2 commits into from
Mar 31, 2020

Conversation

markmandel
Copy link
Member

Must have missed it earlier, but it keeps getting generated by my IDE, so makes sense to check it in.

@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Mar 26, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 17f09d8f-e847-40b0-80ad-e6306aa9d211

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1434/head:pr_1434 && git checkout pr_1434
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-c2f1612

@markmandel markmandel requested review from roberthbailey and removed request for EricFortin March 30, 2020 23:33
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 6c6a8d91-c658-4bd1-ac27-03c923a87761

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1434/head:pr_1434 && git checkout pr_1434
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-8056de5

@roberthbailey roberthbailey merged commit ace7669 into googleforgames:master Mar 31, 2020
@markmandel markmandel deleted the cleanup/stk-go.mod branch March 31, 2020 17:20
@markmandel markmandel added this to the 1.5.0 milestone Apr 7, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@markmandel @ilkercelikyilmaz
Add go.sum to SuperTuxKart example. (googleforgames#1434)
831c5a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@pooneh-m pooneh-m Awaiting requested review from pooneh-m

Assignees

@roberthbailey roberthbailey

Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc size/L
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @agones-bot @google-oss-robot @roberthbailey