Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ErrorHandling for failed to create pods because of forbidden #1400

Merged
merged 1 commit into from
Mar 8, 2020
Merged

Add ErrorHandling for failed to create pods because of forbidden #1400

merged 1 commit into from
Mar 8, 2020

Conversation

suecideTech
Copy link
Contributor

@suecideTech suecideTech commented Mar 7, 2020

When failed to create GameServer Pods becouse of "forbidden", GameServer's STATE remained "Creating".
eg. agones-sdk serviceaccount does not exist

Fixed so that put the reason of error to Event and STATE change to "Error".

Test results

  • Add unit test case and passed.
  • Passed e2e test. (Create GameServer without making agones-sdk serviceaccount)

Closes #1370

Fixed so that put the reason of forbidden error to Event and STATE change to "Error".
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@suecideTech
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@suecideTech
Copy link
Contributor Author

/assign @pooneh-m

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 8d72118a-e44d-48f7-866b-e18b5bf72794

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1400/head:pr_1400 && git checkout pr_1400
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-40e11ac

Copy link
Contributor

@pooneh-m pooneh-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!! Thanks @suecideTech for the change. It is useful with the permission debugging.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pooneh-m, suecideTech

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pooneh-m pooneh-m merged commit 001ffde into googleforgames:master Mar 8, 2020
@markmandel markmandel added this to the 1.5.0 milestone Apr 7, 2020
@markmandel markmandel added area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones labels Apr 7, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
…gleforgames#1400)

Fixed so that put the reason of forbidden error to Event and STATE change to "Error".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GameServer remains "STATE:Creating" if not create serviceaccount
6 participants