Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the kind make targets to work with kind 0.6.0 and later. #1349

Merged
merged 1 commit into from
Feb 20, 2020

Conversation

roberthbailey
Copy link
Member

As described in the breaking changes section for the 0.6.0 release of kind:

You do not need to and should not do export KUBECONFIG="$(kind get kubeconfig-path)". This command is deprecated and will be removed in a future release.

I recently re-installed kind following the current installation instructions and got version 0.7.0 which indeed does remove this command (and our existing make targets were thus rendered broken).

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a1da7446-6f03-46fc-ab63-c2e8347998a8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1349/head:pr_1349 && git checkout pr_1349
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-677838b

@roberthbailey
Copy link
Member Author

/assign @markmandel

@roberthbailey
Copy link
Member Author

[testing our prow webhook, which had been failing]

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you when you say this works 😄

@markmandel markmandel merged commit f092779 into googleforgames:master Feb 20, 2020
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel added area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc and removed approved labels Feb 20, 2020
@markmandel markmandel added this to the 1.4.0 milestone Feb 20, 2020
@roberthbailey roberthbailey deleted the kind-updates branch August 24, 2020 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants