Update documentation for the 1.2 release to use Kubernetes 1.13. #1178

roberthbailey · 2019-11-07T06:04:21Z

Also update links from examples to Kubernetes 1.13 docs.

Closes #1044

/hold

Adding a hold until we can test Kubernetes 1.13 on EKS & AKS.

agones-bot · 2019-11-07T06:18:05Z

Build Succeeded 👏

Build Id: 2284e25e-9b46-44c8-8ad7-5231f09796ea

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.2.0-b38c9fe
image: gcr.io/agones-images/agones-sdk:1.2.0-b38c9fe
image: gcr.io/agones-images/agones-ping:1.2.0-b38c9fe
Linux C++ SDK (build): agonessdk-1.2.0-b38c9fe-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.2.0-b38c9fe.zip

A preview of the website (the last 30 builds are retained):

https://b38c9fe-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1178/head:pr_1178 && git checkout pr_1178
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-b38c9fe

markmandel · 2019-11-07T23:09:00Z

I see your point from before - we can't have a central place, as we couldn't feature block the new version of Kubernetes.

Sounds like find and replace it is!

roberthbailey · 2019-11-07T23:57:19Z

@aLekSer - are you able to test these instructions of EKS / AKS?

agones-bot · 2019-11-08T00:10:11Z

Build Succeeded 👏

Build Id: 81789ae0-7b76-4b31-b728-31c645c55ba8

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.2.0-0a80168
image: gcr.io/agones-images/agones-sdk:1.2.0-0a80168
image: gcr.io/agones-images/agones-ping:1.2.0-0a80168
Linux C++ SDK (build): agonessdk-1.2.0-0a80168-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.2.0-0a80168.zip

A preview of the website (the last 30 builds are retained):

https://0a80168-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1178/head:pr_1178 && git checkout pr_1178
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-0a80168

aLekSer · 2019-11-11T21:27:13Z

Hello @roberthbailey I will test and let you know soon.

aLekSer · 2019-11-11T23:48:39Z

site/content/en/docs/Installation/_index.md

+
+# Create the AKS cluster - this might take some time. Type 'az aks create -h' to see all available options
+# The following command will create a single Node AKS cluster. Node size is Standard A1 v1 and Kubernetes version is 1.13.12. Plus, SSH keys will be generated for you, use --ssh-key-value to provide your values
+az aks create --resource-group $AKS_RESOURCE_GROUP --name $AKS_NAME --node-count 1 --generate-ssh-keys --node-vm-size Standard_A4_v2 --kubernetes-version 1.13.12


This command has executed fine for me, I was able to install agones afterwards using install.yaml.
At the end I have tested deployment with creating a simple-udp fleet.
Running E2E tests right now, I expect that we should increase node-count to 4 as in GKE cluster.

E2E tests are failing. For instance, here:

FAIL: TestPingHTTP (30.11s) ping_test.go:50: Error Trace: ping_test.go:50 Error: Expected nil, but got: &url.Error{Op:"Get", URL:"http://51.105.176.201:80", Err:(*net.OpError)(0xc00040a000)}

I'm happy to increase the node count to 4.

What is the IP address for that can't be fetched? Can you tell if it's because the cluster is too small and there are pending pods?

I need to test one more time, could be connectivity issue between PC running E2E tests and the cluster.

I followed all instructions for AKS cluster, issues does not related to this change.
Something is missing in description on how to create UDP firewall for port range.
Therefore I think I would send a separate PR for the fix of docs to make E2E tests passing on both AKS and EKS.

Thanks for testing this out @aLekSer!

I've adjusted the AKS instructions to create a 4 node cluster instead of a 1 node cluster.

agones-bot · 2019-11-15T00:07:28Z

Build Failed 😱

Build Id: 5e6874b5-8465-4fe0-b0bf-6031afb9340c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-11-15T21:23:27Z

Build Failed 😱

Build Id: cfd179a0-b76e-48b8-aa5e-281b0c7e9f68

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-12-02T18:18:19Z

Build Succeeded 👏

Build Id: 30b80b57-d9a0-4172-b930-57beaf64fa67

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.2.0-b5bdae5
image: gcr.io/agones-images/agones-sdk:1.2.0-b5bdae5
image: gcr.io/agones-images/agones-ping:1.2.0-b5bdae5
Linux C++ SDK (build): agonessdk-1.2.0-b5bdae5-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.2.0-b5bdae5.zip

A preview of the website (the last 30 builds are retained):

https://b5bdae5-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1178/head:pr_1178 && git checkout pr_1178
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-b5bdae5

aLekSer · 2019-12-02T20:55:50Z

Tested this PR on AWS EKS, it works fine.

roberthbailey · 2019-12-03T00:47:44Z

@markmandel - @aLekSer tested this on EKS/AKS and I know I tested on GKE. It's been long enough that I can't remember if I tested on minikube / kind but I think I did. Might be worth one more pass and then we should get this merged.

agones-bot · 2019-12-03T00:59:38Z

Build Failed 😱

Build Id: 3b9e9f28-03e6-461f-a4de-17c70c447919

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-12-03T09:18:34Z

Build Succeeded 👏

Build Id: 0653f809-2361-45e1-a1c2-a305ec86c563

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.2.0-1d95c71
image: gcr.io/agones-images/agones-sdk:1.2.0-1d95c71
image: gcr.io/agones-images/agones-ping:1.2.0-1d95c71
Linux C++ SDK (build): agonessdk-1.2.0-1d95c71-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.2.0-1d95c71.zip

A preview of the website (the last 30 builds are retained):

https://1d95c71-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1178/head:pr_1178 && git checkout pr_1178
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-1d95c71

agones-bot · 2019-12-03T19:27:58Z

Build Succeeded 👏

Build Id: dbe4f143-d07d-4212-9052-9c7b7b6da027

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.2.0-dbffb33
image: gcr.io/agones-images/agones-sdk:1.2.0-dbffb33
image: gcr.io/agones-images/agones-ping:1.2.0-dbffb33
Linux C++ SDK (build): agonessdk-1.2.0-dbffb33-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.2.0-dbffb33.zip

A preview of the website (the last 30 builds are retained):

https://dbffb33-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1178/head:pr_1178 && git checkout pr_1178
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-dbffb33

Also update links from examples to Kubernetes 1.13 docs.

roberthbailey · 2019-12-03T19:57:48Z

I just went through the minikube instructions and verified that they work (and KIND isn't part of this PR -- it's in the developer docs but not part of the user facing website docs).

I made one small fix -- the GKE and minikube sections somehow lost their link pointing users to continue to the installing agones section at the bottom of the page, so I've added that in.

/hold cancel

agones-bot · 2019-12-03T20:09:41Z

Build Succeeded 👏

Build Id: eaf75698-59e9-4742-a888-86e16e18e4c4

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.2.0-2334dec
image: gcr.io/agones-images/agones-sdk:1.2.0-2334dec
image: gcr.io/agones-images/agones-ping:1.2.0-2334dec
Linux C++ SDK (build): agonessdk-1.2.0-2334dec-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.2.0-2334dec.zip

A preview of the website (the last 30 builds are retained):

https://2334dec-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1178/head:pr_1178 && git checkout pr_1178
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-2334dec

google-oss-robot · 2019-12-03T21:01:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…gleforgames#1178) Also update links from examples to Kubernetes 1.13 docs.

google-oss-robot added the do-not-merge/hold label Nov 7, 2019

google-oss-robot requested review from EricFortin and pooneh-m November 7, 2019 06:04

google-oss-robot added approved size/L labels Nov 7, 2019

roberthbailey mentioned this pull request Nov 7, 2019

Upgrade to Kubernetes 1.13 #1044

Closed

roberthbailey force-pushed the documentation-for-1-13 branch from b38c9fe to 0a80168 Compare November 7, 2019 23:56

aLekSer reviewed Nov 11, 2019

View reviewed changes

roberthbailey force-pushed the documentation-for-1-13 branch from 0a80168 to 23ded6c Compare November 14, 2019 23:58

roberthbailey force-pushed the documentation-for-1-13 branch from 23ded6c to 7fc61f9 Compare November 15, 2019 21:07

roberthbailey force-pushed the documentation-for-1-13 branch from 7fc61f9 to b5bdae5 Compare December 2, 2019 18:03

roberthbailey force-pushed the documentation-for-1-13 branch from b5bdae5 to 1d95c71 Compare December 3, 2019 00:46

roberthbailey force-pushed the documentation-for-1-13 branch from 1d95c71 to dbffb33 Compare December 3, 2019 19:15

Update documentation for the 1.2 release to use Kubernetes 1.13.

2334dec

Also update links from examples to Kubernetes 1.13 docs.

roberthbailey force-pushed the documentation-for-1-13 branch from dbffb33 to 2334dec Compare December 3, 2019 19:56

google-oss-robot removed the do-not-merge/hold label Dec 3, 2019

markmandel added kind/documentation Documentation for Agones kind/feature New features for Agones labels Dec 3, 2019

markmandel approved these changes Dec 3, 2019

View reviewed changes

google-oss-robot assigned markmandel Dec 3, 2019

google-oss-robot added the lgtm label Dec 3, 2019

markmandel merged commit 0c8bfc0 into googleforgames:master Dec 3, 2019

markmandel added this to the 1.2.0 milestone Dec 3, 2019

markmandel added the kind/breaking Breaking change label Dec 4, 2019

roberthbailey deleted the documentation-for-1-13 branch August 24, 2020 23:01

ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020

Update documentation for the 1.2 release to use Kubernetes 1.13. (goo…

11715cc

…gleforgames#1178) Also update links from examples to Kubernetes 1.13 docs.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update documentation for the 1.2 release to use Kubernetes 1.13. #1178

Update documentation for the 1.2 release to use Kubernetes 1.13. #1178

roberthbailey commented Nov 7, 2019 •

edited

Loading

agones-bot commented Nov 7, 2019

markmandel commented Nov 7, 2019

roberthbailey commented Nov 7, 2019

agones-bot commented Nov 8, 2019

aLekSer commented Nov 11, 2019

aLekSer Nov 11, 2019 •

edited

Loading

aLekSer Nov 12, 2019 •

edited

Loading

roberthbailey Nov 12, 2019

aLekSer Nov 12, 2019

aLekSer Nov 14, 2019

roberthbailey Nov 14, 2019

roberthbailey Nov 14, 2019

agones-bot commented Nov 15, 2019

agones-bot commented Nov 15, 2019

agones-bot commented Dec 2, 2019

aLekSer commented Dec 2, 2019

roberthbailey commented Dec 3, 2019

agones-bot commented Dec 3, 2019

agones-bot commented Dec 3, 2019

agones-bot commented Dec 3, 2019

roberthbailey commented Dec 3, 2019

agones-bot commented Dec 3, 2019

google-oss-robot commented Dec 3, 2019

Update documentation for the 1.2 release to use Kubernetes 1.13. #1178

Update documentation for the 1.2 release to use Kubernetes 1.13. #1178

Conversation

roberthbailey commented Nov 7, 2019 • edited Loading

agones-bot commented Nov 7, 2019

markmandel commented Nov 7, 2019

roberthbailey commented Nov 7, 2019

agones-bot commented Nov 8, 2019

aLekSer commented Nov 11, 2019

aLekSer Nov 11, 2019 • edited Loading

Choose a reason for hiding this comment

aLekSer Nov 12, 2019 • edited Loading

Choose a reason for hiding this comment

roberthbailey Nov 12, 2019

Choose a reason for hiding this comment

aLekSer Nov 12, 2019

Choose a reason for hiding this comment

aLekSer Nov 14, 2019

Choose a reason for hiding this comment

roberthbailey Nov 14, 2019

Choose a reason for hiding this comment

roberthbailey Nov 14, 2019

Choose a reason for hiding this comment

agones-bot commented Nov 15, 2019

agones-bot commented Nov 15, 2019

agones-bot commented Dec 2, 2019

aLekSer commented Dec 2, 2019

roberthbailey commented Dec 3, 2019

agones-bot commented Dec 3, 2019

agones-bot commented Dec 3, 2019

agones-bot commented Dec 3, 2019

roberthbailey commented Dec 3, 2019

agones-bot commented Dec 3, 2019

google-oss-robot commented Dec 3, 2019

roberthbailey commented Nov 7, 2019 •

edited

Loading

aLekSer Nov 11, 2019 •

edited

Loading

aLekSer Nov 12, 2019 •

edited

Loading