Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add owners files for the C++ code #1118

Merged
merged 1 commit into from
Oct 16, 2019

Conversation

roberthbailey
Copy link
Member

Two reasons:

  1. To document that @devjgm is handling the bulk of the code reviews (especially for style).
  2. This will cause the blunderbuss plugin for prow to auto assign code reviews.

/assign @devjgm

handling the bulk of the code reviews (especially for style).
@google-oss-robot
Copy link

@roberthbailey: GitHub didn't allow me to assign the following users: devjgm.

Note that only googleforgames members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Two reasons:

  1. To document that @devjgm is handling the bulk of the code reviews (especially for style).
  2. This will cause the blunderbuss plugin for prow to auto assign code reviews.

/assign @devjgm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-robot
Copy link

The following users are mentioned in OWNERS file(s) but are not members of the googleforgames org.

Once all users have been added as members of the org, you can trigger verification by writing /verify-owners in a comment.

  • devjgm
    • examples/cpp-simple/OWNERS
    • sdks/cpp/OWNERS

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e7819faa-22ae-451c-9a9d-ffae0ad72531

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1118/head:pr_1118 && git checkout pr_1118
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-264dfa9

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pooneh-m, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pooneh-m,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pooneh-m pooneh-m merged commit a0eb613 into googleforgames:master Oct 16, 2019
@markmandel markmandel added this to the 1.1.0 milestone Oct 22, 2019
@markmandel markmandel added area/meta Organisational matters. e.g. Governance, release cycles, etc. area/tests Unit tests, e2e tests, anything to make sure things don't break labels Oct 22, 2019
@roberthbailey roberthbailey deleted the cpp-sdk-owners branch August 24, 2020 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/meta Organisational matters. e.g. Governance, release cycles, etc. area/tests Unit tests, e2e tests, anything to make sure things don't break do-not-merge/invalid-owners-file lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants