Move Googlers no longer actively reviewing code to emeritus owners

[roberthbailey]

Split out of #1113.

/assign @jkowalski @joeholley @ilkercelikyilmaz

[agones-bot]

Build Succeeded 👏

Build Id: 77ec9ca0-66ff-425b-929d-65f5a0d4ea1f

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.1.0-8308b67
• image: gcr.io/agones-images/agones-sdk:1.1.0-8308b67
• image: gcr.io/agones-images/agones-ping:1.1.0-8308b67
• Linux C++ SDK (build): agonessdk-1.1.0-8308b67-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.1.0-8308b67.zip

A preview of the website (the last 30 builds are retained):

• https://8308b67-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1116/head:pr_1116 && git checkout pr_1116
• helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-8308b67

[ilkercelikyilmaz]

What will be the process to become an active reviewer? Modify this file ?
I assume we can't approve any change while we are emeritus_approver, right?

[agones-bot]

Build Failed 😱

Build Id: 1720b7be-bee8-4786-bd1f-7c573dbe402c

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Succeeded 👏

Build Id: dfbf8a1b-1ee5-4e52-ac29-e1590f6fc55e

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.1.0-f05c40c
• image: gcr.io/agones-images/agones-sdk:1.1.0-f05c40c
• image: gcr.io/agones-images/agones-ping:1.1.0-f05c40c
• Linux C++ SDK (build): agonessdk-1.1.0-f05c40c-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.1.0-f05c40c.zip

A preview of the website (the last 30 builds are retained):

• https://f05c40c-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1116/head:pr_1116 && git checkout pr_1116
• helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-f05c40c

[roberthbailey]

What will be the process to become an active reviewer? Modify this file?
I assume we can't approve any change while we are emeritus_approver, right?

Right now, the owners file is really only used by prow to auto-assign PRs to reviewers. Being moved out of the approvers section means that you won't get PRs assigned to you.

If/when we switch to using prow to automatically merge PRs (rather than click the button) then not being an approver means you can't approve PRs for prow to merge them.

In the current state, you will still be an owner of the repo, still be able to approve PRs, and still be able to manually merge them. You won't lose any permissions (yet).

But you bring up a good question which is that we have a process for promoting folks to be project approvers while we don't have a written policy about the process for becoming emeritus and/or regaining approver powers.

https://github.com/googleforgames/agones/blob/master/docs/governance/community_membership.md#responsibilities-and-privileges says that we expect approvers to "be responsive to review requests in a timely manner". If folks aren't actively reviewing PRs, then I think it's reasonable to say that they are not acting an a project approver any longer.

[roberthbailey]

@joeholley / @jkowalski - any thoughts?

[agones-bot]

Build Succeeded 👏

Build Id: 7e86ddd0-6d42-4a32-8650-bde3aee5cd18

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.2.0-e8cbaeb
• image: gcr.io/agones-images/agones-sdk:1.2.0-e8cbaeb
• image: gcr.io/agones-images/agones-ping:1.2.0-e8cbaeb
• Linux C++ SDK (build): agonessdk-1.2.0-e8cbaeb-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.2.0-e8cbaeb.zip

A preview of the website (the last 30 builds are retained):

• https://e8cbaeb-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1116/head:pr_1116 && git checkout pr_1116
• helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-e8cbaeb

[agones-bot]

Build Succeeded 👏

Build Id: 47950b67-0456-4a36-86b4-6eb9f50293c9

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.2.0-ccd596b
• image: gcr.io/agones-images/agones-sdk:1.2.0-ccd596b
• image: gcr.io/agones-images/agones-ping:1.2.0-ccd596b
• Linux C++ SDK (build): agonessdk-1.2.0-ccd596b-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.2.0-ccd596b.zip

A preview of the website (the last 30 builds are retained):

• https://ccd596b-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1116/head:pr_1116 && git checkout pr_1116
• helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-ccd596b

[google-oss-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment