-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the port to connect to the sdkserver based on the AGONES_SDK_GRPC_PORT environment variable #1092
Set the port to connect to the sdkserver based on the AGONES_SDK_GRPC_PORT environment variable #1092
Conversation
6cd12f8
to
7cd75d9
Compare
Build Failed 😱 Build Id: ff83615a-654f-48f3-bc01-b023b676de44 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: e8bc3b3a-9f09-45d9-81ed-61ccd38bace9 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Succeeded 👏 Build Id: 138fdc1a-f3f7-4ca6-944d-fb311ce66333 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
7cd75d9
to
322c81f
Compare
Build Succeeded 👏 Build Id: 7a7dc901-849a-4194-964d-29d9dbb65fec The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
322c81f
to
3127ef4
Compare
3127ef4
to
265c197
Compare
Build Succeeded 👏 Build Id: ec93a7b6-2fd5-4579-a404-9be74307a877 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Succeeded 👏 Build Id: d21b2333-aaf6-447b-9f1b-b8b04f882dd0 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This looks better to me.
@devjgm: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
41412ed
to
872ebaa
Compare
Build Succeeded 👏 Build Id: a3055946-fd81-4d2e-b528-82dc54d108fd The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Succeeded 👏 Build Id: 72a180c3-551a-4e91-aa55-f29f12c7f401 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: devjgm, pooneh-m, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…_PORT environment variable.
872ebaa
to
10990b1
Compare
New changes are detected. LGTM label has been removed. |
Build Succeeded 👏 Build Id: bfa32a18-2381-42f7-ac9b-09879bd1c2c8 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
@devjgm -- looking for some feedback on the way that I'm getting the environment variable and converting it to an integer. I'm not sure whether either is proper C++ (it felt like I was writing C so I'm guessing there's a better way to do it).
Part of #851.