Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing "/reserve" endpoint description #1083

Merged
merged 1 commit into from
Sep 27, 2019

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Sep 27, 2019

Add curl example for making /reserve request.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e3501813-8f60-4797-89a5-577fd870b9f6

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1083/head:pr_1083 && git checkout pr_1083
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-fe1eff1

Add curl example for making /reserve request.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c2f2ffee-3971-4793-abc4-9264181d21bb

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1083/head:pr_1083 && git checkout pr_1083
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-2e6059b

@markmandel markmandel added kind/documentation Documentation for Agones kind/feature New features for Agones labels Sep 27, 2019
@markmandel markmandel added this to the 1.1.0 milestone Sep 27, 2019
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent catch.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aLekSer, markmandel
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel merged commit 60c09fe into googleforgames:master Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Documentation for Agones kind/feature New features for Agones lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants