Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cyclomatic complexity in examples/simple-udp/server/main.go #178

Closed
EricFortin opened this issue Apr 14, 2018 · 0 comments · Fixed by #207
Closed

Fix cyclomatic complexity in examples/simple-udp/server/main.go #178

EricFortin opened this issue Apr 14, 2018 · 0 comments · Fixed by #207
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! kind/cleanup Refactoring code, fixing up documentation, etc
Milestone
0.2.0

Comments

@EricFortin
Copy link
Collaborator

Remove the // nolint comment.

The main function has a cyclomatic complexity greater than 10. Refactor the function to lower it.
@EricFortin EricFortin added good first issue These are great first issues. If you are looking for a place to start, start here! kind/cleanup Refactoring code, fixing up documentation, etc labels Apr 14, 2018
@EricFortin EricFortin mentioned this issue Apr 14, 2018
Merged
@enocom enocom self-assigned this May 16, 2018
@enocom enocom mentioned this issue May 16, 2018
Merged
markmandel pushed a commit that referenced this issue May 17, 2018
@enocom @markmandel
Shrink main func to resolve gocyclo warning
0e672ef 
Fixes #178
@markmandel markmandel mentioned this issue May 22, 2018
Merged
@markmandel markmandel added this to the 0.2 milestone May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.2.0
Development

Successfully merging a pull request may close this issue.

Shrink main func to resolve gocyclo warning
3 participants
@markmandel @enocom @EricFortin