Update install.yaml to use /live for liveness check

Also, inline health handler function for consistent style.
googleforgames · Feb 23, 2018 · 97ff665 · 97ff665
1 parent e8fe86d
commit 97ff665
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 21 deletions.
diff --git a/build/install.yaml b/build/install.yaml
@@ -155,7 +155,7 @@ spec:
           value: "8000"
         livenessProbe:
           httpGet:
-            path: /healthz
+            path: /live
             port: 8080
           initialDelaySeconds: 3
           periodSeconds: 3
@@ -288,4 +288,4 @@ subjects:
 roleRef:
   apiGroup: rbac.authorization.k8s.io
   kind: ClusterRole
-  name: agones-controller
+  name: agones-controller
diff --git a/cmd/controller/main.go b/cmd/controller/main.go
@@ -141,7 +141,23 @@ func main() {
 			logrus.WithError(err).Fatal("could not run webhook server")
 		}
 	}()
-	go startHealthCheck(health)
+	go func() {
+		logrus.Info("Starting health check...")
+		srv := &http.Server{
+			Addr:    ":8080",
+			Handler: health,
+		}
+		defer srv.Close() // nolint: errcheck
+
+		if err := srv.ListenAndServe(); err != nil {
+			if err == http.ErrServerClosed {
+				logrus.WithError(err).Info("health check: http server closed")
+			} else {
+				err := errors.Wrap(err, "Could not listen on :8080")
+				runtime.HandleError(logrus.WithError(err), err)
+			}
+		}
+	}()
 
 	err = c.Run(2, stop)
 	if err != nil {
@@ -150,21 +166,3 @@ func main() {
 
 	logrus.Info("Shut down gameserver controller")
 }
-
-func startHealthCheck(h healthcheck.Handler) {
-	logrus.Info("Starting health check...")
-	srv := &http.Server{
-		Addr:    ":8080",
-		Handler: h,
-	}
-	defer srv.Close() // nolint: errcheck
-
-	if err := srv.ListenAndServe(); err != nil {
-		if err == http.ErrServerClosed {
-			logrus.WithError(err).Info("health check: http server closed")
-		} else {
-			err := errors.Wrap(err, "Could not listen on :8080")
-			runtime.HandleError(logrus.WithError(err), err)
-		}
-	}
-}